flake8
passed.
JSHint
passed.
Show a better error message when the config file can't be found.
Review Request #10057 — Created July 3, 2018 and submitted
If the config file doesn't exist, we would show a pretty ugly error
message. This change fixes that up to be more user friendly.
Theoretically this might catch other loading errors, but the new error
message should be generic enough to cover that.
Tried running with a missing or malformed config file. Saw the new
error.
-
-
commands/serve.go (Diff revision 1) This still isn't great. The whole thing I ran into is that, if you're just starting out and run the program, you have no idea where to start. I think we should, upon failing to load the config file, say to see the installation docs (http://www.reviewboard.org/docs/rbgateway/1.0/rb-gateway/installation/) to get started.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+4 -3) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
commands/serve.go (Diff revisions 1 - 2) I should have had "latest" instead of "1.0" in my example, since this will get stale fast.
I'm also going to update the tree to not nest "rb-gateway" twice in the URL. So this would need to be:
https://www.reviewboard.org/docs/rbgateway/latest/installation/
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+4 -3) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.