Summary

Show a better error message when the config file can't be found.

Review Request #10057 — Created July 3, 2018 and submitted July 3, 2018, 4:46 p.m.

Information

Owner

david

Repository

rb-gateway

Branch

master

Bugs

Depends On

Commit

8437235...

Reviewers

Groups

rb-gateway

People

Description

If the config file doesn't exist, we would show a pretty ugly error
message. This change fixes that up to be more user friendly.
Theoretically this might catch other loading errors, but the new error
message should be generic enough to cover that.

Testing Done

Tried running with a missing or malformed config file. Saw the new
error.

Issues

Description	From	Last Updated
This still isn't great. The whole thing I ran into is that, if you're just starting out and run the …	chipx86	July 3, 2018, 4:02 p.m.
I should have had "latest" instead of "1.0" in my example, since this will get stale fast. I'm also going …	chipx86	July 3, 2018, 4:36 p.m.

flake8 passed.

JSHint passed.

commands/serve.go (Diff revision 1)

The issue has been resolved. Show all issues

This still isn't great. The whole thing I ran into is that, if you're just starting out and run the program, you have no idea where to start. I think we should, upon failing to load the config file, say to see the installation docs (http://www.reviewboard.org/docs/rbgateway/1.0/rb-gateway/installation/) to get started.

Commit:

8438fbfae5eaf3cff4b90ea5e7c3f9b0c698d1c5

bf1b04ff0e664846e929a93c7df5a4f1b092ad6a

Diff:

Revision 2 (+4 -3)

Show changes

	Gopkg.lock
	commands/serve.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

commands/serve.go (Diff revisions 1 - 2)

The issue has been resolved. Show all issues

I should have had "latest" instead of "1.0" in my example, since this will get stale fast.

I'm also going to update the tree to not nest "rb-gateway" twice in the URL. So this would need to be:

https://www.reviewboard.org/docs/rbgateway/latest/installation/

Commit:

bf1b04ff0e664846e929a93c7df5a4f1b092ad6a

8437235dd9b58d34b8b4deb3686cee0c65a17c98

Diff:

Revision 3 (+4 -3)

Show changes

	Gopkg.lock
	commands/serve.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (7dd711b)