Using "--exit-zero" instead of "ignore_errors" to propagate flake8 internal errors

Review Request #10048 — Created June 29, 2018 and submitted

jcannon
ReviewBot
master
4710
reviewbot

flake8 returns non-zero status if it runs successfully and finds issues. This means the tool had to pass ignore_errors=True in order to ensure flake8 finding issues wasn't reported as internal error.

This would mask actual internal errors however, and would result in the bot reporting that flake8 "passed" in the event of an actual internal error.

Before change -> flake8 passes when an internal error occurs.
After change -> flake8 errors with "internal error".

david
  1. Ship It!
  2. 
      
jcannon
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (3e35fcf)
Loading...