flake8
passed.
JSHint
passed.
Review Request #10048 — Created June 29, 2018 and submitted
flake8
returns non-zero status if it runs successfully and finds issues. This means the tool had to passignore_errors=True
in order to ensureflake8
finding issues wasn't reported asinternal error
.This would mask actual internal errors however, and would result in the bot reporting that
flake8
"passed" in the event of an actual internal error.
Before change ->
flake8
passes when an internal error occurs.
After change ->flake8
errors with "internal error".