Summary

Install Git post-receive hooks to trigger post events

Review Request #10040 — Created June 26, 2018 and submitted July 2, 2018, 3:40 p.m.

Information

Owner

brennie

Repository

rb-gateway

Branch

master

Bugs

Depends On

~~10027~~

Blocks

10041

Commit

c4fe1ea...

Reviewers

Groups

rb-gateway

People

Description

RB Gateway is now capable of installing post-receive hooks in a Git
repository that will execute rb-gateway trigger-webhooks with the
appropriate arguments to cause a push event to occur.

There is now integration test support which (1) builds RB Gateway into a
tmp directory, (2) exports an environment variable pointing to this
location so that tests can find it, and (3) runs go test on the
integration tests which look for this environment variable. These can be
run via make integration-tests. Regular tests should now be ran via
make test, as go test ./... will trigger the integration test suite
and fail (because it has not been set up properly).

Co-authored-by: Florie Cai floriecai@hotmail.com

Testing Done


Ran unit tests.
Ran integration tests.
Ran go fmt ./....

Issues

Description	From	Last Updated
This would be a little cleaner to list all the phony targets once: .PHONY: build test integration-tests build: vendor go …	david	June 27, 2018, 2:57 p.m.

flake8 passed.

JSHint passed.

Depends On:: ~~10027 - Add the trigger-webhooks command~~

Change Summary:: Credit Florie
Description:: RB Gateway is now capable of installing post-receive hooks in a Git
repository that will execute rb-gateway trigger-webhooks with the
appropriate arguments to cause a push event to occur.

There is now integration test support which (1) builds RB Gateway into a
tmp directory, (2) exports an environment variable pointing to this
location so that tests can find it, and (3) runs go test on the
integration tests which look for this environment variable. These can be
run via make integration-tests. Regular tests should now be ran via
make test, as go test ./... will trigger the integration test suite
and fail (because it has not been set up properly).
+
+
Co-authored-by: Florie Cai floriecai@hotmail.com

Makefile (Diff revision 1)

The issue has been resolved. Show all issues

This would be a little cleaner to list all the phony targets once:

.PHONY: build test integration-tests

build: vendor
        go build

vendor:
        dep ensure

...

Commit:

2ed1b61ca7ee0628907ea2b2c5db96518cc38758

c4fe1ea393ae50e30e08cae8e25581f099c23c16

Diff:

Revision 2 (+681 -13)

Show changes

	Gopkg.lock
	Gopkg.toml
	Makefile
	README.md
	config/config.go
	helpers/config.go
	integration_tests/git_hook_test.go
	integration_tests/init.go
	6 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (97435b7)

		RB Gateway is now capable of installing post-receive hooks in a Git
		repository that will execute `rb-gateway trigger-webhooks` with the
		appropriate arguments to cause a `push` event to occur.

		There is now integration test support which (1) builds RB Gateway into a
		tmp directory, (2) exports an environment variable pointing to this
		location so that tests can find it, and (3) runs `go test` on the
		integration tests which look for this environment variable. These can be
		run via `make integration-tests`. Regular tests should now be ran via
		`make test`, as `go test ./...` will trigger the integration test suite
		and fail (because it has not been set up properly).
	+
	+	Co-authored-by: Florie Cai floriecai@hotmail.com