Fix SVN auth/HTTPS support with Subvertpy.

Review Request #10037 — Created June 24, 2018 and submitted

easyb
Review Board
release-3.0.x
acd80cd...
reviewboard

When using Subvertpy as an SCM backend, adding an HTTPS repository
requiring Basic authentication would fail showing:
A repository was not found at the specified path.

Weirdly, when passing the `subvertpy.AUTH_PARAM_DEFAULT_*` constants to
`subvertpy.ra.Auth.auth.set_parameter()` instead of the corresponding
strings, it works.
Also, in `accept_ssl_certificate()` username/password were not passed.

  • Created Docker container form easybe/alpine-reviewboard:wip
  • Sucessfully added an SVN repository requiring HTTPS and Basic auth
Description From Last Updated

Can you add some whitespace to break this up a little? We generally include blank lines around blocks. Something like ...

daviddavid
easyb
easyb
easyb
easyb
david
  1. Thanks so much for this fix! Just one formatting request.

  2. reviewboard/scmtools/svn/subvertpy.py (Diff revision 1)
     
     
     
     
     
     
     
     

    Can you add some whitespace to break this up a little? We generally include blank lines around blocks. Something like this:

    ...
    
    username = self.auth.get_parameter(AUTH_PARAM_DEFAULT_USERNAME)
    
    if username:
        auth.set_parameter(AUTH_PARAM_DEFAULT_USERNAME, B(username))
    
    password = self.auth.get_parameter(AUTH_PARAM_DEFAULT_PASSWORD)
    
    if password:
        auth.set_parameter(AUTH_PARAM_DEFAULT_PASSWORD, B(password))
    
    ...
    
  3. 
      
easyb
chipx86
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
easyb
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (6f22c00)
Loading...