Summary

Create PushPayloads with Mercurial

Review Request #10021 — Created June 14, 2018 and submitted June 29, 2018, 3:15 p.m.

Information

Owner

brennie

Repository

rb-gateway

Branch

master

Bugs

Depends On

~~10018~~, ~~9409~~

Blocks

10022

Commit

3b6813c...

Reviewers

Groups

rb-gateway

People

Description

The Mercurial SCM implementation now supports parsing the environment
created by a changegroup event (which occurs when the repository
receives a set of commits) and creating a PushPayload. This will allow
us to install a Mercurial hook that can hit Review Board to close review
requests mentioned in commits pushed to a Mercurial repository.

The Git implementation is currently a panic() since it cannot
be triggered by anything external. Git support is coming in a future
patch.

Testing Done

Ran go fmt ./....
Ran go test ./....

flake8 passed.

JSHint passed.

Description:: The Mercurial SCM implementation now supports parsing the environment
created by a changegroup event (which occurs when the repository
receives a set of commits) and creating a PushPayload. This will allow
us to install a Mercurial hook that can hit Review Board to close review
requests mentioend in commits pushed to a Mercurial repository.
+
+
The Git implementation is currently a panic() since it cannot
+ be triggered by anything external. Git support is coming in a future
+ patch.

Description:: The Mercurial SCM implementation now supports parsing the environment
created by a changegroup event (which occurs when the repository
receives a set of commits) and creating a PushPayload. This will allow
us to install a Mercurial hook that can hit Review Board to close review
~ requests mentioend in commits pushed to a Mercurial repository.
~ requests mentioned in commits pushed to a Mercurial repository.

The Git implementation is currently a panic() since it cannot
be triggered by anything external. Git support is coming in a future
patch.

Change Summary:

Use HgRepository.Log

Commit:

6ee3b2bf0653e908a27b4c72693695b4432f4d87

3b6813c8046051e350c834544bc699ae14d780e4

Diff:

Revision 2 (+284 -18)

Show changes

	helpers/env.go
	helpers/hg.go
	helpers/repo.go
	repositories/git.go
	repositories/hg.go
	repositories/hg_test.go
	repositories/repository.go
	repositories/events/events.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (daf33ca)

		The Mercurial SCM implementation now supports parsing the environment
		created by a `changegroup` event (which occurs when the repository
		receives a set of commits) and creating a `PushPayload`. This will allow
		us to install a Mercurial hook that can hit Review Board to close review
		requests mentioend in commits pushed to a Mercurial repository.
	+
	+	The Git implementation is currently a `panic()` since it cannot
	+	be triggered by anything external. Git support is coming in a future
	+	patch.