Summary

Add types for branches, commits, and commit metadata

Review Request #10009 — Created June 8, 2018 and submitted June 11, 2018, 5:31 p.m.

Information

Owner

brennie

Repository

rb-gateway

Branch

master

Bugs

Depends On

~~10007~~

Blocks

9409

Commit

2d6e0bf...

Reviewers

Groups

rb-gateway

People

Description

This patch updates our internals to return objects from Repository

methods instead of just returning raw responses. This moves the

serialization code into the API endpoints, instead of having it in every

Repository implementation. This also allows our tests to compare these

structures directly, instead of re-parsing the JSON into a private

struct.
Additionally, the Git unit tests have been updated to use

assert.Equal(expected, actual), which is what the library expects.

Testing Done

Ran go fmt ./....
Ran go test ./....

flake8 passed.

JSHint passed.

Description:: This patch updates our internals to return objects from Repository
methods instead of just returning raw responses. This moves the
serialization code into the API endpoints, instead of having it in every
Repository implementation. This also allows our tests to compare these
structures directly, instead of re-parsing the JSON into a private
struct.
+
+
Additionally, the Git unit tests have been updated to use
+ assert.Equal(expected, actual), which is what the library expects.

Change Summary:

Minor cleanups

Commit:

18e75e527fe0198d453fc72c7759c8e7960dcb8c

abdf1e8fdb88b3a9fc867498c094db7303be7f7b

Diff:

Revision 2 (+126 -178)

Show changes

	api/routes.go
	repositories/git.go
	repositories/git_test.go
	repositories/repository.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Rebase

Depends On:

~~10007 - Reorganize helpers/ package in prep for HG support~~

Commit:

abdf1e8fdb88b3a9fc867498c094db7303be7f7b

2d6e0bf0a24aafe6c7d7e5e4a6d788b84c8c4ff5

Diff:

Revision 3 (+126 -178)

Show changes

	api/routes.go
	repositories/git.go
	repositories/git_test.go
	repositories/repository.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (0df2f27)

		This patch updates our internals to return objects from `Repository`
		methods instead of just returning raw responses. This moves the
		serialization code into the API endpoints, instead of having it in every
		`Repository` implementation. This also allows our tests to compare these
		structures directly, instead of re-parsing the JSON into a private
		struct.
	+
	+	Additionally, the Git unit tests have been updated to use
	+	`assert.Equal(expected, actual)`, which is what the library expects.