Summary

Reorganize helpers/ package in prep for HG support

Review Request #10007 — Created June 7, 2018 and submitted June 11, 2018, 5:30 p.m.

Information

Owner

Repository

rb-gateway

Branch

master

Bugs

Depends On

~~10004~~

Blocks

10009

Commit

767c2d3...

Reviewers

Groups

People

Description

All the repo helpers were focused around Git support. However, we also
are going to be landed Hg support soon and will need some equivalent
methods for Hg. Things have been appropriately renamed appropriately to
reference the fact that they create Git repositories.

Testing Done

Ran go fmt ./....
Ran go test ./....

Issues

Description	From	Last Updated
I don't think you meant to replace on this line.	david	June 8, 2018, 7:28 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Rebase

Depends On:

~~10006 - Validate configuration after loading~~

~~10004 - Use htpasswd for credential storage~~

Commit:

eb3027661fbb5d7f7dfc7883e0c93f4ca7b80c70

5d6e956d79b2f2cb041d0e5a65b7338e89377ebe

Diff:

Revision 2 (+98 -91)

	api/routes_test.go
	config/config_test.go
	helpers/config_helpers.go
	helpers/repo_helpers.go
	helpers/repo.go
	repositories/git_test.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

helpers/git.go (Diff revision 2)
The issue has been resolved. Show all issues
```
I don't think you meant to replace on this line.
```

Change Summary:

address feedback.

Commit:

5d6e956d79b2f2cb041d0e5a65b7338e89377ebe

9054e31552f2b9d8bece7be7d1eedcbfc024b731

Diff:

Revision 3 (+97 -90)

	api/routes_test.go
	config/config_test.go
	helpers/config_helpers.go
	helpers/repo_helpers.go
	helpers/repo.go
	repositories/git_test.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

```
Ship It!
```

Change Summary:

Fix up some tests

Commit:

9054e31552f2b9d8bece7be7d1eedcbfc024b731

767c2d322c12b6fbfe6e20d35a2b8f11cebd6db4

Diff:

Revision 4 (+99 -92)

	api/routes_test.go
	config/config_test.go
	helpers/config_helpers.go
	helpers/repo_helpers.go
	helpers/repo.go
	repositories/git_test.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (e4bc5c5)