Summary:

Clean up tests to use assert.New(t)

Review Request #10002 — Created June 6, 2018 and submitted June 11, 2018, 3:29 p.m.

Information
Owner:	brennie
Repository:	rb-gateway
Branch:	master
Bugs:
Depends On:	~~9999~~
Blocks:	10004
Commit:	e1a9bc6...
Reviewers
Groups:	rb-gateway
People:

Description

The documentation for assert mentions that you should use
assert.New(t) when doing more than one assertion, so this patch
updates all our unit tests to this format. Additionally, a helper method
was updated to accept testing.T and mark itself as a helper so any
crash or error in it will be reported in the correct test.

Testing Done

Ran go test ./...
Ran go fmt ./...

flake8 passed.

JSHint passed.

Description:

~		The documentation for `assert` [1] mentiosn that you should use
	~	The documentation for `assert` mentiosn that you should use
		`assert.New(t)` when doing more than one assertion, so this patch
		updates all our unit tests to this format. Additionally, a helper method
		was updated to accept `testing.T` and mark itself as a helper so any
		crash or error in it will be reported in the correct test.

Description:

~		The documentation for `assert` mentiosn that you should use
	~	The documentation for `assert` mentions that you should use
		`assert.New(t)` when doing more than one assertion, so this patch
		updates all our unit tests to this format. Additionally, a helper method
		was updated to accept `testing.T` and mark itself as a helper so any
		crash or error in it will be reported in the correct test.

Commit:

-	8824381d3db52fcc5a6bd6b169af435aae7e6cc4
+	3ddbd7dde33394185387363518f9f65bec91b46e

Diff:

Revision 2 (+128 -90)

Show changes

	api/routes_test.go
	config/config_test.go
	helpers/config_helpers.go
	helpers/repo_helpers.go
	repositories/git_test.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Depends On:

+	~~9999 - Generate unique tokens for session API~~

Change Summary:

Rebase off /r/10006/

Commit:

-	3ddbd7dde33394185387363518f9f65bec91b46e
+	2b8acd7d124743b321e8a63eee8f8629794e57bf

Diff:

Revision 3 (+128 -90)

Show changes

	api/routes_test.go
	config/config_test.go
	helpers/config_helpers.go
	helpers/repo_helpers.go
	repositories/git_test.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Rebase

Commit:

-	2b8acd7d124743b321e8a63eee8f8629794e57bf
+	e1a9bc6ba2194066da4194d0ecc5f86822088c35

Diff:

Revision 4 (+128 -90)

Show changes

	api/routes_test.go
	config/config_test.go
	helpers/config_helpers.go
	helpers/repo_helpers.go
	repositories/git_test.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (6991583)