agalperin got review request #10000!

Summary

update filter chunks

Review Request #10000 — Created June 5, 2018 and discarded July 27, 2018, 10:37 a.m.

Information

Owner

agalperin

Repository

Review Board

Branch

release-2.5.x

Bugs

4699

Depends On

Reviewers

Groups

reviewboard

People

Description

update filter chunks

Testing Done

Issues

Description	From	Last Updated
E302 expected 2 blank lines, found 1	reviewbot	June 5, 2018, 6 p.m.
E231 missing whitespace after ','	reviewbot	June 5, 2018, 6 p.m.
E231 missing whitespace after ','	reviewbot	June 5, 2018, 6 p.m.
E501 line too long (89 > 79 characters)	reviewbot	June 5, 2018, 6 p.m.
E501 line too long (87 > 79 characters)	reviewbot	June 5, 2018, 6:01 p.m.
E501 line too long (88 > 79 characters)	reviewbot	June 5, 2018, 6:01 p.m.
W603 '<>' is deprecated, use '!='	reviewbot	June 5, 2018, 6:01 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:01 p.m.
E127 continuation line over-indented for visual indent	reviewbot	June 5, 2018, 6:01 p.m.
E501 line too long (83 > 79 characters)	reviewbot	June 5, 2018, 6:01 p.m.
E128 continuation line under-indented for visual indent	reviewbot	June 5, 2018, 6:01 p.m.
E128 continuation line under-indented for visual indent	reviewbot	June 5, 2018, 6:01 p.m.
E231 missing whitespace after ','	reviewbot	June 5, 2018, 6:01 p.m.
E128 continuation line under-indented for visual indent	reviewbot	June 5, 2018, 6:01 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:01 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:01 p.m.
W603 '<>' is deprecated, use '!='	reviewbot	June 5, 2018, 6:01 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:01 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:01 p.m.
E231 missing whitespace after ','	reviewbot	June 5, 2018, 6:01 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:01 p.m.
W603 '<>' is deprecated, use '!='	reviewbot	June 5, 2018, 6:01 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:01 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:02 p.m.
E231 missing whitespace after ','	reviewbot	June 5, 2018, 6:02 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:02 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:02 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:02 p.m.
E701 multiple statements on one line (colon)	reviewbot	June 5, 2018, 6:02 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:02 p.m.
E302 expected 2 blank lines, found 1	reviewbot	June 5, 2018, 6:18 p.m.
E231 missing whitespace after ','	reviewbot	June 5, 2018, 6:18 p.m.
E231 missing whitespace after ','	reviewbot	June 5, 2018, 6:18 p.m.
E127 continuation line over-indented for visual indent	reviewbot	June 5, 2018, 6:18 p.m.
E128 continuation line under-indented for visual indent	reviewbot	June 5, 2018, 6:18 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	June 5, 2018, 6:18 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:18 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:18 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:18 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:18 p.m.
E713 test for membership should be 'not in'	reviewbot	June 5, 2018, 6:18 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:18 p.m.
E231 missing whitespace after ':'	reviewbot	June 5, 2018, 6:18 p.m.
E231 missing whitespace after ':'	reviewbot	June 5, 2018, 6:18 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:18 p.m.
E128 continuation line under-indented for visual indent	reviewbot	June 5, 2018, 6:18 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:18 p.m.
E226 missing whitespace around arithmetic operator	reviewbot	June 5, 2018, 6:19 p.m.
E226 missing whitespace around arithmetic operator	reviewbot	June 5, 2018, 6:19 p.m.
E226 missing whitespace around arithmetic operator	reviewbot	June 5, 2018, 6:19 p.m.
F841 local variable 'e' is assigned to but never used	reviewbot	June 5, 2018, 6:19 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:19 p.m.
E231 missing whitespace after ','	reviewbot	June 5, 2018, 6:19 p.m.
E231 missing whitespace after ','	reviewbot	June 5, 2018, 6:30 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	June 5, 2018, 6:30 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:30 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:30 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:30 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:30 p.m.
E713 test for membership should be 'not in'	reviewbot	June 5, 2018, 6:30 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:30 p.m.
E231 missing whitespace after ':'	reviewbot	June 5, 2018, 6:31 p.m.
E231 missing whitespace after ':'	reviewbot	June 5, 2018, 6:31 p.m.
E225 missing whitespace around operator	reviewbot	June 5, 2018, 6:31 p.m.
E722 do not use bare except'	reviewbot	June 5, 2018, 6:31 p.m.
E231 missing whitespace after ','	reviewbot	June 5, 2018, 6:31 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	June 5, 2018, 6:35 p.m.
E231 missing whitespace after ','	reviewbot	June 6, 2018, 12:17 p.m.
E501 line too long (80 > 79 characters)	reviewbot	June 6, 2018, 12:17 p.m.
E501 line too long (80 > 79 characters)	reviewbot	June 6, 2018, 12:17 p.m.
E203 whitespace before ','	reviewbot	June 6, 2018, 12:23 p.m.

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 62 failures.
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E501 line too long (89 > 79 characters)
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E501 line too long (87 > 79 characters)
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
W603 '<>' is deprecated, use '!='
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
W603 '<>' is deprecated, use '!='
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
W603 '<>' is deprecated, use '!='
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E701 multiple statements on one line (colon)
```
reviewboard/diffviewer/diffutils.py (Diff revision 1)
Show all issues
```
E225 missing whitespace around operator
```

Commit:

-	b32d475cf7008140f51b91e172f7bf035816ef90
+	054825ec2147978648644b0f2955c40a0633b913

Diff:

Revision 2 (+88 -1)

Show changes

	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/opcode_generator.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E126 continuation line over-indented for hanging indent
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E713 test for membership should be 'not in'
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ':'
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ':'
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E226 missing whitespace around arithmetic operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E226 missing whitespace around arithmetic operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E226 missing whitespace around arithmetic operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
F841 local variable 'e' is assigned to but never used
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```

Commit:

-	054825ec2147978648644b0f2955c40a0633b913
+	9d460741df6685174626c0913188ec21d93a80a4

Diff:

Revision 3 (+88 -1)

Show changes

	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/opcode_generator.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/diffviewer/diffutils.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/diffviewer/diffutils.py (Diff revision 3)
Show all issues
```
E126 continuation line over-indented for hanging indent
```
reviewboard/diffviewer/diffutils.py (Diff revision 3)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 3)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 3)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 3)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 3)
Show all issues
```
E713 test for membership should be 'not in'
```
reviewboard/diffviewer/diffutils.py (Diff revision 3)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ':'
```
reviewboard/diffviewer/diffutils.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ':'
```
reviewboard/diffviewer/diffutils.py (Diff revision 3)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/diffviewer/diffutils.py (Diff revision 3)
Show all issues
```
E722 do not use bare except'
```
reviewboard/diffviewer/diffutils.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```

Commit:

-	9d460741df6685174626c0913188ec21d93a80a4
+	ef2c79f8393cc81c8ffae089135c86b876c3e80c

Diff:

Revision 4 (+88 -1)

Show changes

	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/opcode_generator.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/diffviewer/diffutils.py (Diff revision 4)
Show all issues
```
E126 continuation line over-indented for hanging indent
```
reviewboard/diffviewer/diffutils.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```

Commit:

-	ef2c79f8393cc81c8ffae089135c86b876c3e80c
+	ba14d5c54457d1aa8ccf704cc199417d9668be35

Diff:

Revision 5 (+90 -1)

Show changes

	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/opcode_generator.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/diffviewer/diffutils.py (Diff revision 5)
Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/diffviewer/diffutils.py (Diff revision 5)
Show all issues
```
E501 line too long (80 > 79 characters)
```

Bugs:

+	https://hellosplat.com/s/beanbag/tickets/4699/

Commit:

-	ba14d5c54457d1aa8ccf704cc199417d9668be35
+	43376088ecadb0363ca485b5a44681a6f4509cf3

Diff:

Revision 6 (+90 -1)

Show changes

	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/opcode_generator.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/diffviewer/diffutils.py (Diff revision 6)
Show all issues
```
E203 whitespace before ','
```

Commit:

-	43376088ecadb0363ca485b5a44681a6f4509cf3
+	4f93a19daad37d3a8da66c3b0cdacd5cd51bdcc3

Diff:

Revision 7 (+89 -1)

Show changes

	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/opcode_generator.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Unbreaking bug number

Bugs:

-	https://hellosplat.com/s/beanbag/tickets/4699/
+	4699

Review Board 6.0.3 alpha 0 (dev)

agalperin got review request #10000!

update filter chunks

Information

Reviewers

flake8

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Bugs:

Commit:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commit:

Diff:

Checks run (2 succeeded)

Change Summary:

Bugs:

Status: Discarded