Summary

Support for accept a diff via stdin

Review Request #992 — Created Aug. 24, 2009 and discarded

Information

Owner

rhettg

Repository

RBTools

Branch

Bugs

1247

Depends On

Reviewers

Groups

rbtools

People

Description

(Copied from http://reviews.review-board.org/r/937/)

I've had a few cases where it's more convenient to just build the diff myself based on just a select number of
files, or perhaps cleanup through another script. Seemed simple enough to support piping into postreview.

Been using this patch against an older version for a few months, but it would be easier to just have it included upstream.

Testing Done

Used it to create this review.

Change Summary:

Changing review group.

Groups:

-	reviewboard
+	rbtools

I don't really like doing this unconditionally, since anybody who has wrappers to run this from a GUI will break. Can we instead check for a "-" argument and read from stdin in that case? This would make it work much like many other *nix tools.

We have this now using --diff-filename=-. Closing this out.