Add a resource for retrieving a list of commits

Review Request #8922 — Created May 5, 2017 and submitted

Information

gerrit-reviewboard-plugin
master

Reviewers

The CommitListResource, available at
a/projects/<projectName>/all-commits/, returns a list of commit
information entries about the first N (default 30) commits on a
branch. It also supports starting at a specific commit for
pagination support.

Hit the API with ?limit and ?start queries and saw the correct
results.

Description From Last Updated

Inconsistent spacing around =s. Shouldn't have any spaces, I think.

daviddavid

Inconsistent spacing around =s. Shouldn't have any spaces, I think. Also, CNT?

daviddavid

Should we be doing some kind of logging rather than just saying to print to console?

daviddavid

What happens if the commit has no parents?

daviddavid

Wrap this?

daviddavid
brennie
brennie
brennie
david
  1. 
      
  2. Show all issues

    Inconsistent spacing around =s. Shouldn't have any spaces, I think.

  3. Show all issues

    Inconsistent spacing around =s. Shouldn't have any spaces, I think.

    Also, CNT?

    1. It was short for COUNT. :/

  4. Show all issues

    Should we be doing some kind of logging rather than just saying to print to console?

  5. Show all issues

    What happens if the commit has no parents?

    1. The walk that generates these commits (see line 94, 139--) ensures that each commit has exactly a single parent.

    2. In that case, rather than having a conditional, can we assert?

    3. Ping on this?

  6. Show all issues

    Wrap this?

  7. 
      
brennie
brennie
david
  1. Ship It!
  2. 
      
brennie
Review request changed
Status:
Completed