Summary

Integrate artwork.

Review Request #8584 — Created Dec. 30, 2016 and submitted Jan. 3, 2017, 10:49 a.m.

Information

Owner

david

Repository

ReviewBot

Branch

master

Bugs

Depends On

Commit

3d683ce...

Reviewers

Groups

reviewbot

People

Description

This change brings in the artwork for Review Bot, which is used in two places:
the integration list, and the user avatar.

Testing Done


Verified that I could see the logo in the integrations list.
Created a new user for Review Bot and saw that the correct avatar was

  assigned.

Issues

Description	From	Last Updated
How about fetching the username using request.POST.get('reviewbot_user') and then deciding things off of that? Right now we're doing 3 lookups.	chipx86	Dec. 30, 2016, 7:56 p.m.
I don't think the int() is needed. Django, iirc, does the right thing, converting to an int as needed (with …	chipx86	Jan. 3, 2017, 10:49 a.m.

Tool: Pyflakes
Processed Files:
    extension/reviewbotext/views.py
    extension/reviewbotext/integration.py

Ignored Files:
    extension/reviewbotext/static/images/reviewbot.png
    extension/reviewbotext/static/images/reviewbot@2x.png



Tool: PEP8 Style Checker
Processed Files:
    extension/reviewbotext/views.py
    extension/reviewbotext/integration.py

Ignored Files:
    extension/reviewbotext/static/images/reviewbot.png
    extension/reviewbotext/static/images/reviewbot@2x.png

extension/reviewbotext/views.py (Diff revision 1)

The issue has been resolved. Show all issues

How about fetching the username using request.POST.get('reviewbot_user') and then deciding things off of that? Right now we're doing 3 lookups.

Commit:

19ff476ee29a37bdc4ddf62301a15bd9b36053f5

3d683ce04a322927da38e1d402526bbca07060a5

Diff:

Revision 2 (+29 -2)

Show changes

	extension/reviewbotext/integration.py
	extension/reviewbotext/views.py
	extension/reviewbotext/static/images/reviewbot.png
	extension/reviewbotext/static/images/reviewbot@2x.png

Tool: Pyflakes
Processed Files:
    extension/reviewbotext/views.py
    extension/reviewbotext/integration.py

Ignored Files:
    extension/reviewbotext/static/images/reviewbot.png
    extension/reviewbotext/static/images/reviewbot@2x.png



Tool: PEP8 Style Checker
Processed Files:
    extension/reviewbotext/views.py
    extension/reviewbotext/integration.py

Ignored Files:
    extension/reviewbotext/static/images/reviewbot.png
    extension/reviewbotext/static/images/reviewbot@2x.png

Ship it!

extension/reviewbotext/views.py (Diff revisions 1 - 2)

The issue has been resolved. Show all issues

I don't think the int() is needed. Django, iirc, does the right thing, converting to an int as needed (with its own type checking). The old code didn't have it.

Status:: Completed
Change Summary:: Pushed to master (41bde1d)