Clean up review task invocation a bit.

Review Request #8459 — Created Oct. 12, 2016 and submitted

Information

ReviewBot
master
1b25dba...

Reviewers

The way that the review task was triggered was overly complicated, passing
through these relatively opaque "payload" and "request" dictionaries.
This change alters things to move a lot more of the info into their own
parameters.

Triggered Review Bot reviews by posting diffs.

Description From Last Updated

'logging' imported but unused

reviewbotreviewbot

'Profile' imported but unused

reviewbotreviewbot

Same here.

chipx86chipx86

Mind specifying if this is the database ID or display ID?

chipx86chipx86

Missing docstring.

chipx86chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        bot/reviewbot/tasks.py
        extension/reviewbotext/extension.py
        bot/reviewbot/processing/review.py
        extension/reviewbotext/handlers.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        bot/reviewbot/tasks.py
        extension/reviewbotext/extension.py
        bot/reviewbot/processing/review.py
        extension/reviewbotext/handlers.py
    
    
  2. extension/reviewbotext/extension.py (Diff revision 1)
     
     
    Show all issues
     'logging' imported but unused
    
  3. extension/reviewbotext/extension.py (Diff revision 1)
     
     
    Show all issues
     'Profile' imported but unused
    
  4. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        bot/reviewbot/tasks.py
        extension/reviewbotext/extension.py
        bot/reviewbot/processing/review.py
        extension/reviewbotext/handlers.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        bot/reviewbot/tasks.py
        extension/reviewbotext/extension.py
        bot/reviewbot/processing/review.py
        extension/reviewbotext/handlers.py
    
    
  2. 
      
chipx86
  1. 
      
  2. bot/reviewbot/processing/review.py (Diff revision 2)
     
     
     
    Show all issues

    Same here.

  3. bot/reviewbot/tasks.py (Diff revision 2)
     
     
     
    Show all issues

    Mind specifying if this is the database ID or display ID?

  4. bot/reviewbot/tasks.py (Diff revision 2)
     
     
    Show all issues

    Missing docstring.

    1. This method is removed in /r/8442/

  5. 
      
david
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        bot/reviewbot/tasks.py
        extension/reviewbotext/extension.py
        bot/reviewbot/processing/review.py
        extension/reviewbotext/handlers.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        bot/reviewbot/tasks.py
        extension/reviewbotext/extension.py
        bot/reviewbot/processing/review.py
        extension/reviewbotext/handlers.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to master (360fd55)