Summary

Add unit tests for rb_auto_assigner.

Review Request #8438 — Created Sept. 25, 2016 and submitted Sept. 27, 2016, 4:48 p.m.

Information

Owner

mike_conley

Repository

student-sonar

Branch

master

Bugs

Depends On

~~8435~~

Commit

ec55779...

Reviewers

Groups

student-sonar

People

Description

Add unit tests for rb_auto_assigner.

Testing Done

Ran these tests, and they all pass.

Issues

Description	From	Last Updated
These should be together. Also missing from __future__ import unicode_literals. Also missing file docstring.	brennie	Sept. 26, 2016, 6:38 p.m.
Class docstring missing.	brennie	Sept. 26, 2016, 6:44 p.m.
blank line between these.	brennie	Sept. 27, 2016, 2:43 p.m.
list of string	brennie	Sept. 26, 2016, 6:39 p.m.
Oops, I said string but I meant unicode. Sorry.	brennie	Sept. 27, 2016, 2:43 p.m.
"Test"	brennie	Sept. 26, 2016, 6:39 p.m.
mconley doesn't exist as a user, no?	brennie	Sept. 26, 2016, 6:42 p.m.
"Test"	brennie	Sept. 26, 2016, 6:39 p.m.
"Test"	brennie	Sept. 26, 2016, 6:39 p.m.

Tool: Pyflakes
Processed Files:
    misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py



Tool: PEP8 Style Checker
Processed Files:
    misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py

Depends On:

+	~~8435 - Make sure test runner is imported after setting environment up.~~

misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py (Diff revision 1)

The issue has been resolved. Show all issues

These should be together.
Also missing from __future__ import unicode_literals.
Also missing file docstring.

misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Class docstring missing.
```
misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py (Diff revision 1)
The issue has been resolved. Show all issues
```
list of string
```
misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py (Diff revision 1)
```
<3
```
misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py (Diff revision 1)
The issue has been resolved. Show all issues
```
"Test"
```

misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py (Diff revision 1)

The issue has been dropped. Show all issues

mconley doesn't exist as a user, no?

mike_conley Sept. 26, 2016, 6:44 p.m.

Correct, and neither does someone_else. This test is making sure that if there are names in the auto-assign list, if a submitter is not in the list, that they're not auto-assigned.

Or am I missing another problem here?

misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py (Diff revision 1)
The issue has been resolved. Show all issues
```
"Test"
```
misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py (Diff revision 1)
The issue has been resolved. Show all issues
```
"Test"
```

Change Summary:

Closed brennie's issues.

Commit:

-	a7559861af24a6809fd4ce6cd8e4681af299a61c
+	de6fb30596a7893b0c28305f66c5721e84c314c2

Diff:

Revision 2 (+62)

Show changes

misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py

Tool: Pyflakes
Processed Files:
    misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py



Tool: PEP8 Style Checker
Processed Files:
    misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py

misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
blank line between these.
```
misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
Oops, I said string but I meant unicode. Sorry.
```

Commit:

-	de6fb30596a7893b0c28305f66c5721e84c314c2
+	ec55779d6226ee40ef075266a3cac82885f608d7

Diff:

Revision 3 (+63)

Show changes

misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py

Tool: PEP8 Style Checker
Processed Files:
    misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py



Tool: Pyflakes
Processed Files:
    misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Landed in 295eb6cd.