Do some clean-up on the ReviewBot worker code.
Review Request #8433 — Created Sept. 24, 2016 and submitted
This change adds unicode_literals, docstrings, and does some cleanup for the
worker code. I haven't done docstrings for the individual tools because I got
lazy.
Tested that workers still responded correctly.
Description | From | Last Updated |
---|---|---|
Also optional, I think. |
mike_conley | |
Missing env |
mike_conley | |
I think these are optional. At least, there are default args set. |
mike_conley | |
Can we call this queue_name ? |
brennie | |
"File" |
brennie | |
% (...) on next line |
brennie | |
Mind putting a blank line here? |
chipx86 | |
And here. |
chipx86 | |
"temporary" |
chipx86 | |
"bool" |
chipx86 | |
"bool" |
chipx86 | |
"bool" |
chipx86 | |
"bool" |
chipx86 | |
"will only single line comment" might be missing a word or two. |
chipx86 | |
Missing trailing period. |
chipx86 | |
Missing a type. |
chipx86 | |
"bool" |
chipx86 | |
"bool" |
chipx86 | |
"bool" |
chipx86 | |
Missing a type. |
chipx86 | |
"bool" |
chipx86 | |
Missing a "Returns". |
chipx86 | |
"bool" |
chipx86 | |
"bool" |
chipx86 | |
"bool" |
chipx86 | |
:py:attr: is only for class attributes. There's no role for parameters. This should just use standard double backticks. |
chipx86 | |
"bool" |
chipx86 |
-
Tool: Pyflakes Processed Files: bot/reviewbot/tools/process.py bot/reviewbot/tasks.py bot/reviewbot/utils.py bot/reviewbot/tools/__init__.py bot/reviewbot/tools/pyflakes.py bot/reviewbot/tools/pep8.py bot/reviewbot/processing/filesystem.py bot/reviewbot/tools/cpplint.py bot/reviewbot/tools/buildbot.py bot/reviewbot/celery.py bot/reviewbot/tools/cppcheck.py bot/reviewbot/tools/jshint.py bot/reviewbot/__init__.py bot/reviewbot/processing/review.py Tool: PEP8 Style Checker Processed Files: bot/reviewbot/tools/process.py bot/reviewbot/tasks.py bot/reviewbot/utils.py bot/reviewbot/tools/__init__.py bot/reviewbot/tools/pyflakes.py bot/reviewbot/tools/pep8.py bot/reviewbot/processing/filesystem.py bot/reviewbot/tools/cpplint.py bot/reviewbot/tools/buildbot.py bot/reviewbot/celery.py bot/reviewbot/tools/cppcheck.py bot/reviewbot/tools/jshint.py bot/reviewbot/__init__.py bot/reviewbot/processing/review.py
-
Tool: Pyflakes Processed Files: bot/reviewbot/tools/process.py bot/reviewbot/tasks.py bot/reviewbot/utils.py bot/reviewbot/tools/__init__.py bot/reviewbot/tools/pyflakes.py bot/reviewbot/tools/pep8.py bot/reviewbot/processing/filesystem.py bot/reviewbot/tools/cpplint.py bot/reviewbot/tools/buildbot.py bot/reviewbot/celery.py bot/reviewbot/tools/cppcheck.py bot/reviewbot/tools/jshint.py bot/reviewbot/__init__.py bot/reviewbot/processing/review.py Tool: PEP8 Style Checker Processed Files: bot/reviewbot/tools/process.py bot/reviewbot/tasks.py bot/reviewbot/utils.py bot/reviewbot/tools/__init__.py bot/reviewbot/tools/pyflakes.py bot/reviewbot/tools/pep8.py bot/reviewbot/processing/filesystem.py bot/reviewbot/tools/cpplint.py bot/reviewbot/tools/buildbot.py bot/reviewbot/celery.py bot/reviewbot/tools/cppcheck.py bot/reviewbot/tools/jshint.py bot/reviewbot/__init__.py bot/reviewbot/processing/review.py
-
Tool: Pyflakes Processed Files: bot/reviewbot/tools/process.py bot/reviewbot/tasks.py bot/reviewbot/utils.py bot/reviewbot/tools/__init__.py bot/reviewbot/tools/pyflakes.py bot/reviewbot/tools/pep8.py bot/reviewbot/processing/filesystem.py bot/reviewbot/tools/cpplint.py bot/reviewbot/tools/buildbot.py bot/reviewbot/celery.py bot/reviewbot/tools/cppcheck.py bot/reviewbot/tools/jshint.py bot/reviewbot/__init__.py bot/reviewbot/processing/review.py Tool: PEP8 Style Checker Processed Files: bot/reviewbot/tools/process.py bot/reviewbot/tasks.py bot/reviewbot/utils.py bot/reviewbot/tools/__init__.py bot/reviewbot/tools/pyflakes.py bot/reviewbot/tools/pep8.py bot/reviewbot/processing/filesystem.py bot/reviewbot/tools/cpplint.py bot/reviewbot/tools/buildbot.py bot/reviewbot/celery.py bot/reviewbot/tools/cppcheck.py bot/reviewbot/tools/jshint.py bot/reviewbot/__init__.py bot/reviewbot/processing/review.py