Add an ES6Compiler which renames .es6.js to .js.

Review Request #7955 — Created Feb. 10, 2016 and submitted

Information

Djblets
release-0.10.x
bad917a...

Reviewers

Pipeline's built-in ES6Compiler forces one to use the annoying .es6
extension, which breaks a lot of other built-in tooling. This compiler uses the
somewhat more sane .es6.js.

Used this with Review Board.

Description From Last Updated

Only one blank line here.

chipx86chipx86

Can you go into more detail on how this is used in here? Like, how a project consumes it?

chipx86chipx86

Blank line after the docstring.

chipx86chipx86

"bool"

chipx86chipx86

We should probably assert that the file ends with self.input_extension.

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/pipeline/compilers/es6.py
    
    Ignored Files:
        djblets/pipeline/compilers/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/pipeline/compilers/es6.py
    
    Ignored Files:
        djblets/pipeline/compilers/__init__.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. djblets/pipeline/compilers/es6.py (Diff revision 1)
     
     
     
     
     
    Show all issues

    Only one blank line here.

  3. djblets/pipeline/compilers/es6.py (Diff revision 1)
     
     
    Show all issues

    Can you go into more detail on how this is used in here? Like, how a project consumes it?

  4. djblets/pipeline/compilers/es6.py (Diff revision 1)
     
     
     
    Show all issues

    Blank line after the docstring.

  5. djblets/pipeline/compilers/es6.py (Diff revision 1)
     
     
    Show all issues

    "bool"

  6. djblets/pipeline/compilers/es6.py (Diff revision 1)
     
     
    Show all issues

    We should probably assert that the file ends with self.input_extension.

  7. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/pipeline/compilers/es6.py
    
    Ignored Files:
        djblets/pipeline/compilers/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/pipeline/compilers/es6.py
    
    Ignored Files:
        djblets/pipeline/compilers/__init__.py
    
    
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.10.x (2380005)