Summary

Add Extension testing framework in reviewboard

Review Request #7934 — Created Jan. 31, 2016 and discarded Sept. 16, 2016, 10:58 a.m.

Information

Owner

weijie

Repository

Review Board

Branch

release-2.6.x

Bugs

Depends On

~~7932~~

Blocks

8093

Reviewers

Groups

reviewboard

People

Description

Add Extension testing framework in reviewboard

Testing Done

I have create a fake test in a real extension to enable target extension.
I have add the document about the Extension Test Framework in docs/manual/extending/extensions/testing.rst.

Issues

Description	From	Last Updated
'pkg_resources' imported but unused	reviewbot	Jan. 31, 2016, 12:59 p.m.
'Mock' imported but unused	reviewbot	Jan. 31, 2016, 12:59 p.m.
'six' imported but unused	reviewbot	Jan. 31, 2016, 12:59 p.m.
'ExtensionInfo' imported but unused	reviewbot	Jan. 31, 2016, 12:59 p.m.
'RegisteredExtension' imported but unused	reviewbot	Jan. 31, 2016, 12:59 p.m.
'ExtensionHook' imported but unused	reviewbot	Jan. 31, 2016, 12:59 p.m.
'ExtensionHookPoint' imported but unused	reviewbot	Jan. 31, 2016, 12:59 p.m.
'ExtensionManager' imported but unused	reviewbot	Jan. 31, 2016, 12:59 p.m.
'Settings' imported but unused	reviewbot	Jan. 31, 2016, 1 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Jan. 31, 2016, 1 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 3 E303 too many blank lines (2)	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 10 E101 indentation contains mixed spaces and tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:14 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 3 E303 too many blank lines (2)	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 10 E101 indentation contains mixed spaces and tabs	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 42 E127 continuation line over-indented for visual indent	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 29 E127 continuation line over-indented for visual indent	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 41 E127 continuation line over-indented for visual indent	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 50 E225 missing whitespace around operator	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 49 E225 missing whitespace around operator	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 80 E501 line too long (95 > 79 characters)	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 50 W292 no newline at end of file	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 53 E502 the backslash is redundant between brackets	reviewbot	Jan. 31, 2016, 1:15 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Feb. 3, 2016, 8:55 p.m.
local variable 'tests_module' is assigned to but never used	reviewbot	Feb. 3, 2016, 8:56 p.m.
Col: 80 E501 line too long (99 > 79 characters)	reviewbot	Feb. 3, 2016, 8:56 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Feb. 3, 2016, 8:57 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	Feb. 3, 2016, 8:57 p.m.
'primary_widgets' imported but unused	reviewbot	Feb. 4, 2016, 8:53 p.m.
'secondary_widgets' imported but unused	reviewbot	Feb. 4, 2016, 8:53 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Feb. 4, 2016, 8:53 p.m.
'TestModelsLoaderMixin' imported but unused	reviewbot	Feb. 4, 2016, 8:52 p.m.
'WebAPICapabilitiesHook' imported but unused	reviewbot	Feb. 4, 2016, 8:52 p.m.
Col: 62 E261 at least two spaces before inline comment	reviewbot	Feb. 4, 2016, 8:53 p.m.
'BaseWebAPITestCase' imported but unused	reviewbot	Feb. 4, 2016, 8:53 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	Feb. 4, 2016, 8:53 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Feb. 4, 2016, 8:53 p.m.
Col: 43 E265 block comment should start with '# '	reviewbot	Feb. 20, 2016, 2:20 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Feb. 20, 2016, 2:20 p.m.
'logging' imported but unused	reviewbot	Feb. 20, 2016, 2:11 p.m.
'nose' imported but unused	reviewbot	Feb. 20, 2016, 2:11 p.m.
'stat' imported but unused	reviewbot	Feb. 20, 2016, 2:11 p.m.
'warnings' imported but unused	reviewbot	Feb. 20, 2016, 2:11 p.m.
'import_module' imported but unused	reviewbot	Feb. 20, 2016, 2:11 p.m.
'Context' imported but unused	reviewbot	Feb. 20, 2016, 2:12 p.m.
'Template' imported but unused	reviewbot	Feb. 20, 2016, 2:12 p.m.
'ImproperlyConfigured' imported but unused	reviewbot	Feb. 20, 2016, 2:12 p.m.
'django_version' imported but unused	reviewbot	Feb. 20, 2016, 2:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 20, 2016, 2:12 p.m.
'Extension' imported but unused	reviewbot	Feb. 20, 2016, 2:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 21, 2016, 10:36 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Feb. 20, 2016, 2:21 p.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Feb. 20, 2016, 2:21 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 20, 2016, 2:21 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 21, 2016, 10:36 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 21, 2016, 10:36 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 21, 2016, 10:36 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 21, 2016, 10:36 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 21, 2016, 10:37 p.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Feb. 21, 2016, 10:37 p.m.
Col: 38 E127 continuation line over-indented for visual indent	reviewbot	Feb. 21, 2016, 10:37 p.m.
'Context' imported but unused	reviewbot	Feb. 20, 2016, 2:14 p.m.
'Template' imported but unused	reviewbot	Feb. 20, 2016, 2:14 p.m.
'Extension' imported but unused	reviewbot	Feb. 20, 2016, 2:14 p.m.
'TestCase' imported but unused	reviewbot	Feb. 20, 2016, 2:14 p.m.
'get_hosting_service' imported but unused	reviewbot	Feb. 20, 2016, 2:15 p.m.
'HostingService' imported but unused	reviewbot	Feb. 20, 2016, 2:15 p.m.
'Widget' imported but unused	reviewbot	Feb. 20, 2016, 2:15 p.m.
'secondary_widgets' imported but unused	reviewbot	Feb. 20, 2016, 2:15 p.m.
'primary_widgets' imported but unused	reviewbot	Feb. 20, 2016, 2:15 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Feb. 20, 2016, 2:15 p.m.
undefined name 'TestExtension'	reviewbot	Feb. 20, 2016, 2:18 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 11 E128 continuation line under-indented for visual indent	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 10 E101 indentation contains mixed spaces and tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 3 W292 no newline at end of file	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:18 p.m.
'call_command' imported but unused	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 3 W292 no newline at end of file	reviewbot	Feb. 25, 2016, 5:20 p.m.
'settings' imported but unused	reviewbot	Feb. 25, 2016, 5:19 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:19 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:19 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:18 p.m.
'call_command' imported but unused	reviewbot	Feb. 25, 2016, 5:18 p.m.
'BaseTestRunner' imported but unused	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:19 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:19 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:18 p.m.
'run_tests' imported but unused	reviewbot	Feb. 25, 2016, 5:19 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Feb. 25, 2016, 5:18 p.m.
local variable 'mixin' is assigned to but never used	reviewbot	Feb. 25, 2016, 5:18 p.m.
Col: 71 E202 whitespace before ')'	reviewbot	Feb. 25, 2016, 5:19 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Feb. 25, 2016, 5:19 p.m.
Col: 3 W292 no newline at end of file	reviewbot	Feb. 25, 2016, 3:35 p.m.
'call_command' imported but unused	reviewbot	Feb. 25, 2016, 3:36 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:19 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:19 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:19 p.m.
'run_tests' imported but unused	reviewbot	Feb. 25, 2016, 3:40 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 3:40 p.m.
'get_extension_manager' imported but unused	reviewbot	Feb. 25, 2016, 3:40 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 3:40 p.m.
local variable 'mixin' is assigned to but never used	reviewbot	Feb. 25, 2016, 3:40 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Feb. 25, 2016, 5:19 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Feb. 25, 2016, 5:19 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	Feb. 25, 2016, 5:19 p.m.
undefined name 'RegisteredExtension'	reviewbot	Feb. 25, 2016, 5:19 p.m.
Col: 3 W292 no newline at end of file	reviewbot	Feb. 25, 2016, 5:04 p.m.
'call_command' imported but unused	reviewbot	Feb. 25, 2016, 5:04 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:04 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:20 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:11 p.m.
'run_tests' imported but unused	reviewbot	Feb. 25, 2016, 5:11 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:11 p.m.
'get_extension_manager' imported but unused	reviewbot	Feb. 25, 2016, 5:11 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 25, 2016, 5:11 p.m.
local variable 'mixin' is assigned to but never used	reviewbot	Feb. 25, 2016, 5:11 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Feb. 25, 2016, 5:20 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Feb. 25, 2016, 5:20 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	Feb. 25, 2016, 5:20 p.m.
undefined name 'RegisteredExtension'	reviewbot	Feb. 25, 2016, 5:20 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
Out of curiosity, why are you still hardcoding this to your TestExtension dummy extension?	mike_conley	March 13, 2016, 12:38 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
undefined name 'RUNNING_TEST'	reviewbot	March 15, 2016, 9:48 p.m.
undefined name 'REVIEWBOARD_ROOT'	reviewbot	March 15, 2016, 9:48 p.m.
undefined name 'STATIC_ROOT'	reviewbot	March 15, 2016, 9:49 p.m.
Col: 1 W391 blank line at end of file	reviewbot	March 15, 2016, 9:49 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
'RegisteredExtension' imported but unused	reviewbot	March 15, 2016, 9:49 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
'logging' imported but unused	reviewbot	March 15, 2016, 9:49 p.m.
'sys' imported but unused	reviewbot	March 15, 2016, 9:49 p.m.
'import_module' imported but unused	reviewbot	March 15, 2016, 9:50 p.m.
'ImproperlyConfigured' imported but unused	reviewbot	March 15, 2016, 9:50 p.m.
'Extension' imported but unused	reviewbot	March 15, 2016, 9:50 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	March 15, 2016, 9:50 p.m.
Col: 9 E303 too many blank lines (2)	reviewbot	March 15, 2016, 9:50 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	March 15, 2016, 9:50 p.m.
undefined name 'self'	reviewbot	March 15, 2016, 10:19 p.m.
undefined name 'module_dir'	reviewbot	March 15, 2016, 10:18 p.m.
Col: 26 E128 continuation line under-indented for visual indent	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 15, 2016, 10:18 p.m.
Col: 9 E126 continuation line over-indented for hanging indent	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 17, 2016, 11:12 p.m.
Col: 80 E501 line too long (102 > 79 characters)	reviewbot	March 17, 2016, 11:12 p.m.
undefined name 'HTDOCS_ROOT'	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
Col: 9 E126 continuation line over-indented for hanging indent	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:12 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:13 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 17, 2016, 11:13 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 17, 2016, 11:13 p.m.
Col: 80 E501 line too long (102 > 79 characters)	reviewbot	March 17, 2016, 11:13 p.m.
'djblets' imported but unused	reviewbot	March 17, 2016, 11:13 p.m.
Col: 43 E127 continuation line over-indented for visual indent	reviewbot	March 17, 2016, 11:24 p.m.
Col: 80 E501 line too long (91 > 79 characters)	reviewbot	March 17, 2016, 11:15 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	March 17, 2016, 11:16 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	March 17, 2016, 11:16 p.m.
Col: 1 W391 blank line at end of file	reviewbot	March 17, 2016, 11:16 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 29, 2016, 3:24 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 29, 2016, 3:24 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 29, 2016, 3:24 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 22, 2016, 9:17 p.m.
'os' imported but unused	reviewbot	March 17, 2016, 11:18 p.m.
'sys' imported but unused	reviewbot	March 17, 2016, 11:18 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 22, 2016, 9:17 p.m.
Col: 80 E501 line too long (102 > 79 characters)	reviewbot	March 17, 2016, 11:20 p.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	March 17, 2016, 11:21 p.m.
Col: 41 E128 continuation line under-indented for visual indent	reviewbot	March 22, 2016, 9:18 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 22, 2016, 9:17 p.m.
Col: 1 W391 blank line at end of file	reviewbot	March 22, 2016, 9:17 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 22, 2016, 9:17 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 29, 2016, 3:24 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 29, 2016, 3:24 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 22, 2016, 9:17 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	March 22, 2016, 9:17 p.m.
Col: 45 E127 continuation line over-indented for visual indent	reviewbot	March 22, 2016, 9:17 p.m.
Col: 41 E128 continuation line under-indented for visual indent	reviewbot	March 22, 2016, 11:34 p.m.
Col: 29 E128 continuation line under-indented for visual indent	reviewbot	March 22, 2016, 11:34 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 29, 2016, 3:24 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 29, 2016, 3:24 p.m.
'get_extension_manager' imported but unused	reviewbot	March 22, 2016, 11:20 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 29, 2016, 3:24 p.m.
Col: 46 E128 continuation line under-indented for visual indent	reviewbot	March 22, 2016, 11:34 p.m.
Col: 45 E128 continuation line under-indented for visual indent	reviewbot	March 22, 2016, 11:34 p.m.
Col: 41 E128 continuation line under-indented for visual indent	reviewbot	March 22, 2016, 11:44 p.m.
Col: 80 E501 line too long (91 > 79 characters)	reviewbot	March 22, 2016, 11:43 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 29, 2016, 3:24 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 29, 2016, 3:24 p.m.
Col: 43 E231 missing whitespace after ','	reviewbot	March 23, 2016, 1:10 a.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 29, 2016, 3:24 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 29, 2016, 3:24 p.m.
I think these are leftovers - they're unrelated to this patch.	mike_conley	April 5, 2016, 8:58 p.m.
We might want to add something about "extension-test" to this database name string.	mike_conley	April 5, 2016, 9:11 p.m.
One too many newlines?	mike_conley	April 5, 2016, 7:56 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 29, 2016, 3:24 p.m.
Can you quickly explain why you need to do the imports down here? I assume it's a legitimate reason, like …	mike_conley	April 5, 2016, 8:58 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	March 29, 2016, 3:24 p.m.
Can you please add a docstring to this?	mike_conley	April 5, 2016, 8:38 p.m.
See my comment in /r/7932 re: test_labels. I'm not sure we need this.	mike_conley	April 5, 2016, 8:39 p.m.
Can you quickly document why this is required?	mike_conley	April 5, 2016, 8:03 p.m.
I think this mixin's responsibilities are a little different... it looks like it's responsible for taking care of the boilerplate …	mike_conley	April 5, 2016, 8:41 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	April 5, 2016, 8:58 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	April 5, 2016, 8:58 p.m.
'os' imported but unused	reviewbot	April 5, 2016, 9:10 p.m.
'VERSION' imported but unused	reviewbot	April 5, 2016, 9:10 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	April 5, 2016, 9:10 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	April 5, 2016, 9:10 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	April 5, 2016, 9:17 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	April 5, 2016, 9:17 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	April 6, 2016, 3:06 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	April 6, 2016, 3:06 p.m.
'VERSION' imported but unused	reviewbot	April 7, 2016, 11:38 a.m.
Col: 1 E402 module level import not at top of file	reviewbot	April 7, 2016, 11:38 a.m.
I don't think this comment is very clear. Perhaps it should be something like: We need to do these imports …	mike_conley	April 7, 2016, 11:44 a.m.
Col: 1 E402 module level import not at top of file	reviewbot	April 7, 2016, 11:38 a.m.
I don't think "Mixin" needs to be capitalized here. Perhaps better wording: A mixin that helps tests to setup and …	mike_conley	April 7, 2016, 11:44 a.m.
Col: 1 E402 module level import not at top of file	reviewbot	April 7, 2016, 11:59 a.m.
Col: 1 E402 module level import not at top of file	reviewbot	April 7, 2016, 11:59 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/testing/extensions.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/extensions.py


WARNING: Number of comments exceeded maximum, showing 30 of 72.

reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'pkg_resources' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'Mock' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'six' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'ExtensionInfo' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'RegisteredExtension' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'ExtensionHook' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'ExtensionHookPoint' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'ExtensionManager' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'Settings' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 3
 E303 too many blank lines (2)
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 10
 E101 indentation contains mixed spaces and tabs
```

Diff:

Revision 2 (+95)

Show changes

reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/testing/extensions.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/extensions.py


WARNING: Number of comments exceeded maximum, showing 30 of 73.

reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 3
 E303 too many blank lines (2)
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 10
 E101 indentation contains mixed spaces and tabs
```

Diff:

Revision 3 (+92)

Show changes

reviewboard/testing/extensions.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/extensions.py



Tool: Pyflakes
Processed Files:
    reviewboard/testing/extensions.py

reviewboard/testing/extensions.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/testing/extensions.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 42
 E127 continuation line over-indented for visual indent
```
reviewboard/testing/extensions.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 29
 E127 continuation line over-indented for visual indent
```
reviewboard/testing/extensions.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 41
 E127 continuation line over-indented for visual indent
```
reviewboard/testing/extensions.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 50
 E225 missing whitespace around operator
```
reviewboard/testing/extensions.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 49
 E225 missing whitespace around operator
```
reviewboard/testing/extensions.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (95 > 79 characters)
```
reviewboard/testing/extensions.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 50
 W292 no newline at end of file
```

Diff:

Revision 4 (+94)

Show changes

reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/testing/extensions.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/extensions.py

reviewboard/testing/extensions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 53
 E502 the backslash is redundant between brackets
```

Diff:

Revision 5 (+94)

Show changes

reviewboard/testing/extensions.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/extensions.py



Tool: Pyflakes
Processed Files:
    reviewboard/testing/extensions.py

Diff:

Revision 6 (+127)

Show changes

reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/testing/extensions.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/extensions.py

reviewboard/testing/extensions.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/testing/extensions.py (Diff revision 6)
The issue has been resolved. Show all issues
```
 local variable 'tests_module' is assigned to but never used
```
reviewboard/testing/extensions.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (99 > 79 characters)
```
reviewboard/testing/extensions.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/testing/extensions.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```

Diff:

Revision 7 (+126)

Show changes

reviewboard/testing/extensions.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/extensions.py



Tool: Pyflakes
Processed Files:
    reviewboard/testing/extensions.py

Testing Done:

	+	command Line: ./reviewboard/manage.py test -- testing.extensions
	+	for test

Diff:

Revision 8 (+153)

Show changes

reviewboard/testing/extensions.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/extensions.py



Tool: Pyflakes
Processed Files:
    reviewboard/testing/extensions.py

reviewboard/testing/extensions.py (Diff revision 8)
The issue has been resolved. Show all issues
```
 'primary_widgets' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 8)
The issue has been resolved. Show all issues
```
 'secondary_widgets' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```

Diff:

Revision 9 (+237)

Show changes

reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/testing/extensions.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/extensions.py

reviewboard/testing/extensions.py (Diff revision 9)
The issue has been resolved. Show all issues
```
 'TestModelsLoaderMixin' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 9)
The issue has been resolved. Show all issues
```
 'WebAPICapabilitiesHook' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 9)
The issue has been resolved. Show all issues
```
Col: 62
 E261 at least two spaces before inline comment
```
reviewboard/testing/extensions.py (Diff revision 9)
The issue has been resolved. Show all issues
```
 'BaseWebAPITestCase' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 9)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
reviewboard/testing/extensions.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```

Diff:

Revision 10 (+235)

Show changes

reviewboard/testing/extensions.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/extensions.py



Tool: Pyflakes
Processed Files:
    reviewboard/testing/extensions.py

reviewboard/testing/extensions.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 43
 E265 block comment should start with '# '
```
reviewboard/testing/extensions.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```

Diff:

Revision 11 (+121)

Show changes

	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/testing/extensions.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py



Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py

reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'logging' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'nose' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'stat' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'warnings' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'import_module' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'Context' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'Template' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'ImproperlyConfigured' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'django_version' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'Extension' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 38
 E127 continuation line over-indented for visual indent
```
reviewboard/testing/extensions.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'Context' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'Template' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'Extension' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'TestCase' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'get_hosting_service' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'HostingService' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'Widget' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'secondary_widgets' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 'primary_widgets' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/testing/extensions.py (Diff revision 11)
The issue has been resolved. Show all issues
```
 undefined name 'TestExtension'
```

Diff:

Revision 12 (+116)

Show changes

	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py

reviewboard/extensions/testing/runner.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 11
 E128 continuation line under-indented for visual indent
```
reviewboard/extensions/testing/runner.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 10
 E101 indentation contains mixed spaces and tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/testing/extensions.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```

Diff:

Revision 13 (+145)

Show changes

	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 3
 W292 no newline at end of file
```
reviewboard/extensions/testing/runner.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 13)
The issue has been resolved. Show all issues
```
 'call_command' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/extensions/testing/runner.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
reviewboard/testing/extensions.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```

Diff:

Revision 14 (+146)

Show changes

	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py



Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Col: 3
 W292 no newline at end of file
```
reviewboard/extensions/testing/runner.py (Diff revision 14)
The issue has been resolved. Show all issues
```
 'settings' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 14)
The issue has been resolved. Show all issues
```
 'call_command' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 14)
The issue has been resolved. Show all issues
```
 'BaseTestRunner' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 14)
The issue has been resolved. Show all issues
```
 'run_tests' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/extensions/testing/runner.py (Diff revision 14)
The issue has been resolved. Show all issues
```
 local variable 'mixin' is assigned to but never used
```
reviewboard/extensions/testing/runner.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Col: 71
 E202 whitespace before ')'
```
reviewboard/testing/extensions.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```

Diff:

Revision 15 (+155 -3)

Show changes

	.reviewboardrc
	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 3
 W292 no newline at end of file
```
reviewboard/extensions/testing/runner.py (Diff revision 15)
The issue has been resolved. Show all issues
```
 'call_command' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 15)
The issue has been resolved. Show all issues
```
 'run_tests' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 15)
The issue has been resolved. Show all issues
```
 'get_extension_manager' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 15)
The issue has been resolved. Show all issues
```
 local variable 'mixin' is assigned to but never used
```
reviewboard/testing/extensions.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/testing/extensions.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/testing/extensions.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
reviewboard/testing/extensions.py (Diff revision 15)
The issue has been resolved. Show all issues
```
 undefined name 'RegisteredExtension'
```

Diff:

Revision 16 (+155 -3)

Show changes

	.reviewboardrc
	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc



Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 16)
The issue has been resolved. Show all issues
```
Col: 3
 W292 no newline at end of file
```
reviewboard/extensions/testing/runner.py (Diff revision 16)
The issue has been resolved. Show all issues
```
 'call_command' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 16)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 16)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 16)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 16)
The issue has been resolved. Show all issues
```
 'run_tests' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 16)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 16)
The issue has been resolved. Show all issues
```
 'get_extension_manager' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 16)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 16)
The issue has been resolved. Show all issues
```
 local variable 'mixin' is assigned to but never used
```
reviewboard/testing/extensions.py (Diff revision 16)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/testing/extensions.py (Diff revision 16)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/testing/extensions.py (Diff revision 16)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
reviewboard/testing/extensions.py (Diff revision 16)
The issue has been resolved. Show all issues
```
 undefined name 'RegisteredExtension'
```

Diff:

Revision 17 (+150 -3)

Show changes

	.reviewboardrc
	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc

reviewboard/extensions/testing/runner.py (Diff revision 17)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

reviewboard/testing/extensions.py (Diff revision 17)

The issue has been resolved. Show all issues

Out of curiosity, why are you still hardcoding this to your TestExtension dummy extension?

Diff:

Revision 18 (+146 -3)

Show changes

	.reviewboardrc
	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc



Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 18)
The issue has been resolved. Show all issues
```
 undefined name 'RUNNING_TEST'
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 18)
The issue has been resolved. Show all issues
```
 undefined name 'REVIEWBOARD_ROOT'
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 18)
The issue has been resolved. Show all issues
```
 undefined name 'STATIC_ROOT'
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```
reviewboard/extensions/testing/runner.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 18)
The issue has been resolved. Show all issues
```
 'RegisteredExtension' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/testing/extensions.py (Diff revision 18)
The issue has been resolved. Show all issues
```
 'logging' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 18)
The issue has been resolved. Show all issues
```
 'sys' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 18)
The issue has been resolved. Show all issues
```
 'import_module' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 18)
The issue has been resolved. Show all issues
```
 'ImproperlyConfigured' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 18)
The issue has been resolved. Show all issues
```
 'Extension' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
reviewboard/testing/extensions.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Col: 9
 E303 too many blank lines (2)
```
reviewboard/testing/extensions.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```

Diff:

Revision 19 (+141 -3)

Show changes

	.reviewboardrc
	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 19)
The issue has been resolved. Show all issues
```
 undefined name 'self'
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 19)
The issue has been resolved. Show all issues
```
 undefined name 'module_dir'
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 19)
The issue has been resolved. Show all issues
```
Col: 26
 E128 continuation line under-indented for visual indent
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 19)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 19)
The issue has been resolved. Show all issues
```
Col: 9
 E126 continuation line over-indented for hanging indent
```
reviewboard/extensions/testing/runner.py (Diff revision 19)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 19)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 19)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/testing/extensions.py (Diff revision 19)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/testing/extensions.py (Diff revision 19)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/testing/extensions.py (Diff revision 19)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/testing/extensions.py (Diff revision 19)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/testing/extensions.py (Diff revision 19)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (102 > 79 characters)
```

Diff:

Revision 20 (+141 -3)

Show changes

	.reviewboardrc
	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 20)
The issue has been resolved. Show all issues
```
 undefined name 'HTDOCS_ROOT'
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 20)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 20)
The issue has been resolved. Show all issues
```
Col: 9
 E126 continuation line over-indented for hanging indent
```
reviewboard/extensions/testing/runner.py (Diff revision 20)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 20)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 20)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/testing/extensions.py (Diff revision 20)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/testing/extensions.py (Diff revision 20)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/testing/extensions.py (Diff revision 20)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/testing/extensions.py (Diff revision 20)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/testing/extensions.py (Diff revision 20)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (102 > 79 characters)
```

Diff:

Revision 21 (+176 -3)

Show changes

	.reviewboardrc
	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 21)
The issue has been resolved. Show all issues
```
 'djblets' imported but unused
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 21)
The issue has been resolved. Show all issues
```
Col: 43
 E127 continuation line over-indented for visual indent
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 21)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (91 > 79 characters)
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 21)
The issue has been resolved. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 21)
The issue has been resolved. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 21)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```
reviewboard/extensions/testing/runner.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 21)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/testing/extensions.py (Diff revision 21)
The issue has been resolved. Show all issues
```
 'os' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 21)
The issue has been resolved. Show all issues
```
 'sys' imported but unused
```
reviewboard/testing/extensions.py (Diff revision 21)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/testing/extensions.py (Diff revision 21)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (102 > 79 characters)
```
reviewboard/testing/extensions.py (Diff revision 21)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```

Diff:

Revision 22 (+176 -3)

Show changes

	.reviewboardrc
	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 22)
The issue has been resolved. Show all issues
```
Col: 41
 E128 continuation line under-indented for visual indent
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 22)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 22)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```
reviewboard/extensions/testing/runner.py (Diff revision 22)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 22)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 22)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/testing/extensions.py (Diff revision 22)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/testing/extensions.py (Diff revision 22)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/testing/extensions.py (Diff revision 22)
The issue has been resolved. Show all issues
```
Col: 45
 E127 continuation line over-indented for visual indent
```

Diff:

Revision 23 (+107 -3)

Show changes

	.reviewboardrc
	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc



Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 23)
The issue has been resolved. Show all issues
```
Col: 41
 E128 continuation line under-indented for visual indent
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 23)
The issue has been resolved. Show all issues
```
Col: 29
 E128 continuation line under-indented for visual indent
```
reviewboard/extensions/testing/runner.py (Diff revision 23)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 23)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 23)
The issue has been resolved. Show all issues
```
 'get_extension_manager' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 23)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/testing/extensions.py (Diff revision 23)
The issue has been resolved. Show all issues
```
Col: 46
 E128 continuation line under-indented for visual indent
```
reviewboard/testing/extensions.py (Diff revision 23)
The issue has been resolved. Show all issues
```
Col: 45
 E128 continuation line under-indented for visual indent
```

Diff:

Revision 24 (+105 -3)

Show changes

	.reviewboardrc
	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc



Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 24)
The issue has been resolved. Show all issues
```
Col: 41
 E128 continuation line under-indented for visual indent
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 24)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (91 > 79 characters)
```
reviewboard/extensions/testing/runner.py (Diff revision 24)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 24)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

Diff:

Revision 25 (+108 -3)

Show changes

	.reviewboardrc
	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 25)
The issue has been resolved. Show all issues
```
Col: 43
 E231 missing whitespace after ','
```
reviewboard/extensions/testing/runner.py (Diff revision 25)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 25)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

Diff:

Revision 26 (+108 -3)

Show changes

	.reviewboardrc
	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc



Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py
    .reviewboardrc

reviewboard/extensions/testing/runner.py (Diff revision 26)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 26)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

Summary:

-	[WIP]add Extension testing framework in reviewboard
+	Add Extension testing framework in reviewboard

Description:

~		[WIP]add Extension testing framework in reviewboard
	~	Add Extension testing framework in reviewboard

Testing Done:

~		command Line: ./reviewboard/manage.py test -- testing.extensions
	~	I have create a fake test in a real extension to enable target extension.
-		for test

Testing Done:

~		I have create a fake test in a real extension to enable target extension.
	~	I have create a fake test in a real extension to enable target extension.
	+	I have add the document about the Extension Test Framework in docs/manual/extending/extensions/testing.rst.

Depends On:

+	~~7932 - Add BaseTestRunner in djblet~~

.reviewboardrc (Diff revision 26)

The issue has been resolved. Show all issues

I think these are leftovers - they're unrelated to this patch.

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 26)

The issue has been resolved. Show all issues

We might want to add something about "extension-test" to this database name string.

weijie April 5, 2016, 9:04 p.m.

Should I write the os.path.join(ROOT_PATH,'extension-test.db') or just 'extension-test.db'

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 26)
The issue has been resolved. Show all issues
```
One too many newlines?
```

reviewboard/extensions/testing/runner.py (Diff revision 26)

The issue has been resolved. Show all issues

Can you quickly explain why you need to do the imports down here? I assume it's a legitimate reason, like the PATH munging you're doing needs to come before you import django.conf.settings...
If so, can you please add a comment about why it's necessary to do these imports down here?

weijie April 5, 2016, 8:45 p.m.

I might need that to update the settings.TEST_PACKAGES = [extension name].

reviewboard/extensions/testing/runner.py (Diff revision 26)
The issue has been resolved. Show all issues
```
Can you please add a docstring to this?
```
reviewboard/extensions/testing/runner.py (Diff revision 26)
The issue has been resolved. Show all issues
```
See my comment in /r/7932 re: test_labels. I'm not sure we need this.
```
reviewboard/testing/extensions.py (Diff revision 26)
The issue has been resolved. Show all issues
```
Can you quickly document why this is required?
```
1. WE
  
  weijie April 5, 2016, 8:45 p.m.
  sorry, that should be a part, I am not clean

reviewboard/testing/extensions.py (Diff revision 26)

The issue has been resolved. Show all issues

I think this mixin's responsibilities are a little different... it looks like it's responsible for taking care of the boilerplate for setting up and tearing down the Extension.

Branch:

-	master
+	release-2.6.x

Diff:

Revision 27 (+110)

Show changes

	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py



Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py

reviewboard/extensions/testing/runner.py (Diff revision 27)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 27)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

Diff:

Revision 28 (+104)

Show changes

	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 28)
The issue has been resolved. Show all issues
```
 'os' imported but unused
```
reviewboard/extensions/testing/conf/settings_local.py (Diff revision 28)
The issue has been resolved. Show all issues
```
 'VERSION' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 28)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 28)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

Diff:

Revision 29 (+100)

Show changes

	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py

reviewboard/extensions/testing/runner.py (Diff revision 29)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 29)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

Diff:

Revision 30 (+100)

Show changes

	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py



Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py

reviewboard/extensions/testing/runner.py (Diff revision 30)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 30)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

Diff:

Revision 31 (+110)

Show changes

	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py

reviewboard/extensions/testing/conf/settings_local.py (Diff revision 31)
The issue has been resolved. Show all issues
```
 'VERSION' imported but unused
```
reviewboard/extensions/testing/runner.py (Diff revision 31)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 31)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

reviewboard/extensions/testing/runner.py (Diff revision 31)

The issue has been resolved. Show all issues

I don't think this comment is very clear.

Perhaps it should be something like:

We need to do these imports after we set the DJANGO_SETTINGS_MODULE in order to make sure the tests get that change.

Something along those lines, anyhow.

reviewboard/testing/extensions.py (Diff revision 31)

The issue has been resolved. Show all issues

I don't think "Mixin" needs to be capitalized here.

Perhaps better wording:

A mixin that helps tests to setup and teardown an extension.

Diff:

Revision 32 (+110)

Show changes

	reviewboard/extensions/testing/__init__.py
	reviewboard/extensions/testing/runner.py
	reviewboard/extensions/testing/conf/settings_local.py
	reviewboard/testing/extensions.py

Tool: Pyflakes
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/extensions/testing/runner.py
    reviewboard/extensions/testing/conf/settings_local.py
    reviewboard/testing/extensions.py

Ignored Files:
    reviewboard/extensions/testing/__init__.py

reviewboard/extensions/testing/runner.py (Diff revision 32)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```
reviewboard/extensions/testing/runner.py (Diff revision 32)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

Status: Discarded

Change Summary:

A similar but separate implementation has been landed for Djblets 0.10