Summary

Implement FBInfer tool in ReviewBot (WIP)

Review Request #7702 — Created Oct. 15, 2015 and discarded Jan. 29, 2019, 1:41 p.m.

Information

Owner

calvinjshin

Repository

ReviewBot

Branch

release-0.2.x

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description

Add a new static analysis tool for Android/iOS code in ReviewBot.
FBInfer is essentially another static analysis tool, like pep8 or pyflakes, that provides automatic feedback on bugs in Android/iOS apps. 
This feature will add support for code written in Java, Objective-C, and C, so that Review Bot can automatically provide bug feedback regarding a review request in these languages. This is a useful tool for Review Bot to have because as of now, there are only tools for code written in Python and C++. Because a lot of programmers use Java, Objective-C, and C, especially for mobile development, it would be helpful for Review Bot to provide support for such languages.

Testing Done

I have tested using a local server and instance of ReviewBoard. From the testing I did, FBInfer didn't seem to be working at all to compile and provide feedback of the files.

Issues

Description	From	Last Updated
You are going to want to add .idea to your global git ignore.	brennie	Oct. 23, 2015, 3:39 p.m.
Can you revert this change? This typo is actually fixed already in master (but not release-0.2.x, which is why you're …	anselina	Oct. 23, 2015, 10:50 p.m.
Needs a docstring.	chipx86	Oct. 23, 2015, 10:49 p.m.
Col: 21 E127 continuation line over-indented for visual indent	reviewbot	Nov. 23, 2015, 6:25 p.m.
Col: 14 E251 unexpected spaces around keyword / parameter equals	reviewbot	Nov. 23, 2015, 6:25 p.m.
Col: 12 E251 unexpected spaces around keyword / parameter equals	reviewbot	Nov. 23, 2015, 6:25 p.m.
Col: 5 E128 continuation line under-indented for visual indent	reviewbot	Nov. 23, 2015, 6:25 p.m.
Col: 5 E122 continuation line missing indentation or outdented	reviewbot	Nov. 23, 2015, 6:25 p.m.
I believe the executable is actually just infer, instead of fbinfer.	anselina	Oct. 23, 2015, 10:51 p.m.
Col: 5 E122 continuation line missing indentation or outdented	reviewbot	Nov. 23, 2015, 6:25 p.m.
endswith can take a tuple of strings to check. I suggest defining a tuple of allowed file types on the …	chipx86	Oct. 23, 2015, 3:39 p.m.
Col: 13 E131 continuation line unaligned for hanging indent	reviewbot	Nov. 23, 2015, 6:25 p.m.
Blank line between these.	chipx86	Oct. 23, 2015, 4:21 p.m.
Col: 15 E251 unexpected spaces around keyword / parameter equals	reviewbot	Nov. 23, 2015, 6:25 p.m.
Col: 13 E251 unexpected spaces around keyword / parameter equals	reviewbot	Nov. 23, 2015, 6:25 p.m.
Col: 17 E251 unexpected spaces around keyword / parameter equals	reviewbot	Nov. 23, 2015, 6:25 p.m.
Col: 15 E251 unexpected spaces around keyword / parameter equals	reviewbot	Nov. 23, 2015, 6:25 p.m.
infer instead of fbinfer.	anselina	Oct. 23, 2015, 10:51 p.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 23, 2015, 6:25 p.m.
Col: 1 W391 blank line at end of file	reviewbot	Nov. 23, 2015, 6:25 p.m.
Col: 1 W391 blank line at end of file	reviewbot	Nov. 23, 2015, 6:25 p.m.
The PyCharm-specific files should not be included in this review request. To remove the .idea/* files from this RR, you …	anselina	Oct. 31, 2015, 2:04 p.m.
Can you remove the extra space between """ and Performs...?	anselina	Oct. 31, 2015, 2:04 p.m.
"Perform" (imperitive mood) Also, this should read something like: """A ReviewBot tool for FBInfer. FBInfer is a static analysis tool …	brennie	Oct. 31, 2015, 2:27 p.m.
Blank line between these.	brennie	Oct. 31, 2015, 2:28 p.m.
Add a period at the end of this sentence.	anselina	Oct. 31, 2015, 2:04 p.m.
... for mobile apps.	brennie	Oct. 31, 2015, 2:28 p.m.
Col: 21 E127 continuation line over-indented for visual indent	reviewbot	Nov. 23, 2015, 6:24 p.m.
Until you implement options for the infer executable, let's get rid of this variable altogether?	anselina	Oct. 31, 2015, 2:04 p.m.
We don't wan't this running on all java, [obj]c[++] files, so there should probably be per-repository settings for the tool …	brennie	Oct. 28, 2015, 3:26 p.m.
You can lose the outer parentheses here.	david	Oct. 31, 2015, 2:05 p.m.
This can all be on one line.	david	Oct. 31, 2015, 2:05 p.m.
This can be condensed down to a single statement: line_num, col, msg = line.split(':', 3)[1:]	david	Oct. 31, 2015, 2:25 p.m.
We don't really need to coerce these to integers because we're not doing any processing with them.	brennie	Nov. 9, 2015, 12:40 a.m.
Col: 1 W391 blank line at end of file	reviewbot	Nov. 23, 2015, 6:24 p.m.
This should not be in the project's .gitignore. This should be in your ~/.gitignore_global.	brennie	Nov. 15, 2015, 5:24 p.m.
Remove this file.	brennie	Nov. 23, 2015, 6:19 p.m.
"This tool performs..."	brennie	Nov. 10, 2015, 8:20 p.m.
I would put this all on the next line.	brennie	Nov. 23, 2015, 6:18 p.m.
Col: 21 E127 continuation line over-indented for visual indent	reviewbot	Nov. 23, 2015, 6:23 p.m.
Perhaps to avoid having to do all these repeated endswith() checks, we could instead get the extension and look it …	AD adriano	Nov. 9, 2015, 9:55 a.m.
This should be infer -- javac path	brennie	Nov. 11, 2015, 12:12 a.m.
This should be infer -- gcc -c path	brennie	Nov. 11, 2015, 12:12 a.m.
This should be infer -- clang path	brennie	Nov. 11, 2015, 12:12 a.m.
Col: 1 W391 blank line at end of file	reviewbot	Nov. 23, 2015, 6:23 p.m.
Col: 21 E127 continuation line over-indented for visual indent	reviewbot	Nov. 23, 2015, 6:19 p.m.
Col: 1 W391 blank line at end of file	reviewbot	Nov. 23, 2015, 6:22 p.m.
'logging' imported but unused	reviewbot	Nov. 23, 2015, 6:22 p.m.
Col: 21 E127 continuation line over-indented for visual indent	reviewbot	Nov. 23, 2015, 6:22 p.m.
Col: 13 E265 block comment should start with '# '	reviewbot	Nov. 23, 2015, 6:23 p.m.
Col: 13 E265 block comment should start with '# '	reviewbot	Nov. 23, 2015, 6:23 p.m.
Col: 13 E265 block comment should start with '# '	reviewbot	Nov. 23, 2015, 6:23 p.m.
Col: 1 W391 blank line at end of file	reviewbot	Nov. 23, 2015, 6:23 p.m.
I think the addition of .idea to your .gitignore file shouldn't be commited to the repository and should instead remain …	AH ahache	Nov. 27, 2015, 8:29 a.m.
Col: 20 W292 no newline at end of file	reviewbot	Nov. 27, 2015, 12:33 a.m.
'logging' imported but unused	reviewbot	Dec. 4, 2015, 11:12 p.m.
Col: 17 E265 block comment should start with '# '	reviewbot	Dec. 4, 2015, 11:12 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Dec. 4, 2015, 11:12 p.m.
Col: 17 E265 block comment should start with '# '	reviewbot	Dec. 4, 2015, 11:12 p.m.

Tool: PEP8 Style Checker
Processed Files:
    bot/reviewbot/tools/fbinfer.py
    bot/reviewbot/tools/cppcheck.py

Ignored Files:
    .idea/.name
    .idea/misc.xml
    .idea/ReviewBot.iml
    .idea/modules.xml
    .idea/vcs.xml
    .idea/workspace.xml

bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 21
 E127 continuation line over-indented for visual indent
```
bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 14
 E251 unexpected spaces around keyword / parameter equals
```
bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 12
 E251 unexpected spaces around keyword / parameter equals
```
bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5
 E128 continuation line under-indented for visual indent
```
bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5
 E122 continuation line missing indentation or outdented
```
bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5
 E122 continuation line missing indentation or outdented
```
bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 13
 E131 continuation line unaligned for hanging indent
```
bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 15
 E251 unexpected spaces around keyword / parameter equals
```
bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 13
 E251 unexpected spaces around keyword / parameter equals
```
bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 17
 E251 unexpected spaces around keyword / parameter equals
```
bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 15
 E251 unexpected spaces around keyword / parameter equals
```

bot/reviewbot/tools/fbinfer.py (Diff revision 1)

The issue has been resolved. Show all issues

Col: 9
 E123 closing bracket does not match indentation of opening bracket's line

bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```
bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```

.idea/.name (Diff revision 1)

The issue has been resolved. Show all issues

You are going to want to add .idea to your global git ignore.

Unfortunately, this summary and description is difficult for us to work with, since we have to then look up or remember what your project is, and other students or contributors to Review Board will have no idea.

You should make sure that you have a detailed, informative review request. See https://www.reviewboard.org/docs/codebase/dev/writing-good-descriptions/

This shouldn't include any of the files under .idea.

bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs a docstring.
```

bot/reviewbot/tools/fbinfer.py (Diff revision 1)

The issue has been resolved. Show all issues

endswith can take a tuple of strings to check. I suggest defining a tuple of allowed file types on the class and passing that in. For example:

class FBINferTool(Tool):
    ...

    ALLOWED_EXTENSIONS = ('.java', '.c', '.h', '.m', '.mm')

    ...

    def handle_file(self, f):
        if not (f.dest_file.endswith(self.ALLOWED_EXTENSIONS)):
            ...

bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```

Looks like you're on the right path! The workers find installed tools through entry points, so you'll need to add a new entry-point for Infer in bot/setup.py before you can test it.

bot/reviewbot/tools/cppcheck.py (Diff revision 1)

The issue has been resolved. Show all issues

Can you revert this change? This typo is actually fixed already in master (but not release-0.2.x, which is why you're seeing this).

bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
I believe the executable is actually just infer, instead of fbinfer.
```
bot/reviewbot/tools/fbinfer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
infer instead of fbinfer.
```

Change Summary:

Fixed a couple issues (Barret, Christian, Anselina) and implemented almost everything for FBInfer tool in ReviewBot.

Summary:

First project, first code drop (WIP)

Fixed a couple issues (Barret, Christian, Anselina) and implemented almost everything for FBInfer tool in ReviewBot.

Description:

~		First project, first code drop (WIP)
	~	I fixed issues regarding many different things, such as adding the .idea file to .gitignore.
	+
	+	Code-wise, I feel that I have completed majority of the code for the tool to be tested, which is the next step. To be more specific, I still need to implement the call to "execute" function. I have asked Anselina regarding confusion I have with this, in terms of the argument passing.

Testing Done:

~		This is my first project, my first code drop. I have begun to implement the FBInfer plugin for ReviewBot.
	~	Have not tested this feature so far.

Diff:

Revision 2 (+937)

Show changes

	.gitignore
	.idea/.name
	.idea/ReviewBot.iml
	.idea/misc.xml
	.idea/modules.xml
	.idea/vcs.xml
	.idea/workspace.xml
	bot/reviewbot/tools/fbinfer.py

Tool: PEP8 Style Checker
Processed Files:
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore
    .idea/misc.xml
    .idea/ReviewBot.iml
    .idea/modules.xml
    .idea/vcs.xml
    .idea/workspace.xml



Tool: Pyflakes
Processed Files:
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore
    .idea/misc.xml
    .idea/ReviewBot.iml
    .idea/modules.xml
    .idea/vcs.xml
    .idea/workspace.xml

bot/reviewbot/tools/fbinfer.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 21
 E127 continuation line over-indented for visual indent
```
bot/reviewbot/tools/fbinfer.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```

Summary:: Fixed a couple issues (Barret, Christian, Anselina) and implemented almost everything for FBInfer tool in ReviewBot.
Fixed a couple issues (Barret, Christian, Anselina) and implemented almost everything for FBInfer tool in ReviewBot (WIP)

The summary and description are going into the commit message, so they need to be self-describing and make sense independently of any code or other discussions taking place. You can reference this guide for some examples: https://www.reviewboard.org/docs/codebase/dev/writing-good-descriptions/

Looks like you should be ready to test the Infer tool this week!

.gitignore (Diff revision 2)

The issue has been resolved. Show all issues

The PyCharm-specific files should not be included in this review request. To remove the .idea/* files from this RR, you will probably need to do something like:

git rm .idea/*
git commit -m "Removed IDEA files."
rbt post -r 7702

brennie Oct. 26, 2015, 8:12 p.m.

Once you do that, you should do the following:

git config --global core.excludesfile '~/.gitignore_global'
echo >> .idea/* ~/.gitignore_global

That way, .idea files will never be added.

brennie Oct. 26, 2015, 8:13 p.m.

That second line has a typo!
It should be:

echo '.idea/*' >> ~/.gitignore_global


Sorry!

bot/reviewbot/tools/fbinfer.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you remove the extra space between """ and Performs...?
```
bot/reviewbot/tools/fbinfer.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Add a period at the end of this sentence.
```

bot/reviewbot/tools/fbinfer.py (Diff revision 2)

The issue has been resolved. Show all issues

Until you implement options for the infer executable, let's get rid of this variable altogether?

Summary:: Fixed a couple issues (Barret, Christian, Anselina) and implemented almost everything for FBInfer tool in ReviewBot (WIP)
Implement FBInfer tool in ReviewBot (WIP)
Description:: ~
I fixed issues regarding many different things, such as adding the .idea file to .gitignore.
~
Add a new static analysis tool for Android/iOS code in ReviewBot.

~
Code-wise, I feel that I have completed majority of the code for the tool to be tested, which is the next step. To be more specific, I still need to implement the call to "execute" function. I have asked Anselina regarding confusion I have with this, in terms of the argument passing.
~
FBInfer is essentially another static analysis tool, like pep8 or pyflakes, that provides automatic feedback on bugs in Android/iOS apps.
+
+
This feature will add support for code written in Java, Objective-C, and C, so that Review Bot can automatically provide bug feedback regarding a review request in these languages. This is a useful tool for Review Bot to have because as of now, there are only tools for code written in Python and C++. Because a lot of programmers use Java, Objective-C, and C, especially for mobile development, it would be helpful for Review Bot to provide support for such languages.

david Oct. 28, 2015, 1:16 p.m.

Oh, also, if you've fixed issues raised in previous reviews, please mark them as "Fixed".

calvinjshin Oct. 31, 2015, 2:31 p.m.

Hi David, do you want me to mark the ReviewBot issues as "Fixed" as well?

david Nov. 2, 2015, 2:22 p.m.

Yes. We use the open-issue count as a way of prioritizing when we review things, so if there are a bunch of open issues, we're less likely to look at it. Whenever you fix anything (regardless of the reviewer), please close the issues.

bot/reviewbot/tools/fbinfer.py (Diff revision 2)
The issue has been resolved. Show all issues
```
You can lose the outer parentheses here.
```
bot/reviewbot/tools/fbinfer.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This can all be on one line.
```

bot/reviewbot/tools/fbinfer.py (Diff revision 2)

The issue has been resolved. Show all issues

This can be condensed down to a single statement:

line_num, col, msg = line.split(':', 3)[1:]

Fix it!

bot/reviewbot/tools/fbinfer.py (Diff revision 2)

The issue has been resolved. Show all issues

"Perform" (imperitive mood)
Also, this should read something like:

"""A ReviewBot tool for FBInfer.

FBInfer is a static analysis tool for mobile apps written in ObjC, Java, and C.
"""

bot/reviewbot/tools/fbinfer.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Blank line between these.
```
bot/reviewbot/tools/fbinfer.py (Diff revision 2)
The issue has been resolved. Show all issues
```
... for mobile apps.
```

bot/reviewbot/tools/fbinfer.py (Diff revision 2)

An issue was opened. Show all issues

We don't wan't this running on all java, [obj]c[++] files, so there should probably be per-repository settings for the tool
(Forgive me if this is already a thing Review Bot does -- I'm not super familiar with it.)

calvinjshin Oct. 31, 2015, 2:31 p.m.

Ah okay, so it should only be running on mobile apps right?

brennie Nov. 2, 2015, 2:29 p.m.
```
Yes.
```

bot/reviewbot/tools/fbinfer.py (Diff revision 2)

The issue has been resolved. Show all issues

We don't really need to coerce these to integers because we're not doing any processing with them.

CA

calvinjshin Oct. 31, 2015, 2:31 p.m.
```
Hey Barret, what do you mean by this?
```

brennie Nov. 2, 2015, 2:29 p.m.

What I mean is, you don't need to call int() here because you're not doing integer-specific things with the values -- you're putting them into a string. It'll be faster if you don't use int()

Change Summary:

Added/Changed the logic of executing different compilers according to the different file types.

Testing Done:

~		Have not tested this feature so far.
	~	I have tested using a local server and instance of ReviewBoard. From the testing I did, FBInfer didn't seem to be working at all to compile and provide feedback of the files.

Diff:

Revision 3 (+71)

Show changes

	.gitignore
	.idea/.name
	bot/setup.py
	bot/reviewbot/tools/fbinfer.py

Tool: Pyflakes
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore



Tool: PEP8 Style Checker
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore

bot/reviewbot/tools/fbinfer.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 21
 E127 continuation line over-indented for visual indent
```
bot/reviewbot/tools/fbinfer.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```

Fix it!

bot/reviewbot/tools/fbinfer.py (Diff revision 3)

An issue was opened. Show all issues

Perhaps to avoid having to do all these repeated endswith() checks, we could instead get the extension and look it up in a precomputed dictionary. For example, something like:
import os

COMPILER_MAP = {
    '.java': 'javac',
    '.h': 'gcc',
    '.c': 'gcc',
    '.m': 'clang',
    '.mm': 'clang',
}

# ... other code goes here ...

def handle_file(self, f):
    extension = os.path.splitext(f.dest_file)[1]
    compiler = COMPILER_MAP.get(extension, None)

    if not compiler:
        return False

    path = f.get_patched_file_path()

    if not path:
        return False

    output = execute(
        [compiler, path],
        split_lines=True,
        ignore_errors=True
    )

    # ... rest of code goes here ...

bot/reviewbot/tools/fbinfer.py (Diff revision 3)
The issue has been resolved. Show all issues
```
"This tool performs..."
```
bot/reviewbot/tools/fbinfer.py (Diff revision 3)
The issue has been resolved. Show all issues
```
I would put this all on the next line.
```
bot/reviewbot/tools/fbinfer.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This should be infer -- javac path
```
bot/reviewbot/tools/fbinfer.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This should be infer -- gcc -c path
```
bot/reviewbot/tools/fbinfer.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This should be infer -- clang path
```

.gitignore (Diff revision 3)

The issue has been resolved. Show all issues

This should not be in the project's .gitignore. This should be in your ~/.gitignore_global.

.idea/.name (Diff revision 3)
The issue has been resolved. Show all issues
```
Remove this file.
```

Change Summary:

Fixed minor issues (different compiler types)

Diff:

Revision 4 (+71)

Show changes

	.gitignore
	.idea/.name
	bot/setup.py
	bot/reviewbot/tools/fbinfer.py

Tool: Pyflakes
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore



Tool: PEP8 Style Checker
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore

bot/reviewbot/tools/fbinfer.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 21
 E127 continuation line over-indented for visual indent
```
bot/reviewbot/tools/fbinfer.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```

Change Summary:

Changed code to attempt to display output in ReviewBot

Diff:

Revision 5 (+77)

Show changes

	.gitignore
	.idea/.name
	bot/setup.py
	bot/reviewbot/tools/fbinfer.py

Tool: PEP8 Style Checker
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore



Tool: Pyflakes
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore

bot/reviewbot/tools/fbinfer.py (Diff revision 5)
The issue has been resolved. Show all issues
```
 'logging' imported but unused
```
bot/reviewbot/tools/fbinfer.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 21
 E127 continuation line over-indented for visual indent
```
bot/reviewbot/tools/fbinfer.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 13
 E265 block comment should start with '# '
```
bot/reviewbot/tools/fbinfer.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 13
 E265 block comment should start with '# '
```
bot/reviewbot/tools/fbinfer.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 13
 E265 block comment should start with '# '
```
bot/reviewbot/tools/fbinfer.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```

Change Summary:

Fixed several issues that were raised.

Diff:

Revision 6 (+76)

Show changes

	.gitignore
	.idea/.name
	bot/setup.py
	bot/reviewbot/tools/fbinfer.py

Fix it!

Tool: Pyflakes
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore



Tool: PEP8 Style Checker
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore

bot/reviewbot/tools/fbinfer.py (Diff revision 6)
An issue was opened. Show all issues
```
Col: 20
 W292 no newline at end of file
```

Fix it!

.gitignore (Diff revision 6)

An issue was opened. Show all issues

I think the addition of .idea to your .gitignore file shouldn't be commited to the repository and should instead remain only on your local setup.
One approach to doing this would be to revert this change, and once it's resolved, you can add both .idea to your ignore file, as well as .gitignore, that way changes done to it won't be tracked.
There may be a better way of doing this, but this is how I've done it before.

Diff:

Revision 7 (+79)

Show changes

	.gitignore
	.idea/.name
	bot/setup.py
	bot/reviewbot/tools/fbinfer.py

Fix it!

Tool: Pyflakes
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore



Tool: PEP8 Style Checker
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore

bot/reviewbot/tools/fbinfer.py (Diff revision 7)
An issue was opened. Show all issues
```
 'logging' imported but unused
```
bot/reviewbot/tools/fbinfer.py (Diff revision 7)
An issue was opened. Show all issues
```
Col: 17
 E265 block comment should start with '# '
```
bot/reviewbot/tools/fbinfer.py (Diff revision 7)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
bot/reviewbot/tools/fbinfer.py (Diff revision 7)
An issue was opened. Show all issues
```
Col: 17
 E265 block comment should start with '# '
```

Status:: Discarded

~		I fixed issues regarding many different things, such as adding the .idea file to .gitignore.
	~	Add a new static analysis tool for Android/iOS code in ReviewBot.

~		Code-wise, I feel that I have completed majority of the code for the tool to be tested, which is the next step. To be more specific, I still need to implement the call to "execute" function. I have asked Anselina regarding confusion I have with this, in terms of the argument passing.
	~	FBInfer is essentially another static analysis tool, like pep8 or pyflakes, that provides automatic feedback on bugs in Android/iOS apps.
	+
	+	This feature will add support for code written in Java, Objective-C, and C, so that Review Bot can automatically provide bug feedback regarding a review request in these languages. This is a useful tool for Review Bot to have because as of now, there are only tools for code written in Python and C++. Because a lot of programmers use Java, Objective-C, and C, especially for mobile development, it would be helpful for Review Bot to provide support for such languages.