Summary

Integration admin page

Review Request #7106 — Created March 23, 2015 and discarded April 28, 2016, 2:20 a.m.

Information

Owner

xuanyi

Repository

Review Board

Branch

master

Bugs

Depends On

~~6918~~, ~~7105~~

Blocks

7221, 7136

Reviewers

Groups

reviewboard, students

People

Description

The integration admin page provides a single interface to manage all the configured integrations. Admmin user can add, delete, change or toggle the state of the integration through this interface. On this page, the admin user will get to see all the configured integrations within the user's permission settings. Each of these integrations will be group according to their integration type, with a simple description and possible actions.

All of the interaction are achieved through the backbone model, which relies on the integration WebApiResource.

Testing Done

Unit test done.

Manual testing on the integration page.

Toggle of state
Delete of integration
Multiple integration class
Single integration class

Files

Issues

Description	From	Last Updated
"Respresents" Also, maybe capitalize integration	CR cristocrat	April 6, 2015, 6:58 a.m.
"... an integration class"	CR cristocrat	April 6, 2015, 6:57 a.m.
maybe get rid of the first "the"	CR cristocrat	April 6, 2015, 6:57 a.m.
maybe reword to: "... ConfiguredIntegration object, which provides enabling or disabling of the instance."	CR cristocrat	April 6, 2015, 6:58 a.m.
provides (with an s)	CR cristocrat	April 6, 2015, 6:58 a.m.
provides (with an s)	CR cristocrat	April 6, 2015, 6:58 a.m.
Maybe capitalize integration	CR cristocrat	April 6, 2015, 6:57 a.m.
"It will also provide a link to create a new instance of this"	CR cristocrat	April 6, 2015, 6:57 a.m.
"This will load a configured..."	CR cristocrat	April 6, 2015, 6:57 a.m.
"...objects that belong to..."	CR cristocrat	April 6, 2015, 6:57 a.m.
"Displays a configured integration in a Manage Integration list."	CR cristocrat	April 6, 2015, 6:57 a.m.
will with two l's "...deleting of the instance."	CR cristocrat	April 6, 2015, 6:58 a.m.
"This destroys..." "... by calling HTTP DLETE..."	CR cristocrat	April 6, 2015, 6:57 a.m.
destroy typo	CR cristocrat	April 6, 2015, 6:57 a.m.
This should use RB.BaseResource, which handles URLs, parsing, etc.	david	May 19, 2015, 6 p.m.
I doubt we want to append another period--all the error strings in webapi/errors.py have text that ends in a period.	david	May 19, 2015, 6 p.m.
I doubt we want to append another period--all the error strings in webapi/errors.py have text that ends in a period.	david	May 19, 2015, 6 p.m.
This should use RB.BaseResource, which handles URLs, parsing, etc.	david	May 19, 2015, 6 p.m.
The "Add" text should be passed in as a variable, and run through gettext().	david	May 19, 2015, 6 p.m.
This text should be passed in and run through gettext().	david	May 19, 2015, 6 p.m.
This text should be run through gettext().	david	May 19, 2015, 6 p.m.
We shouldn't add another period.	david	May 19, 2015, 6 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js

Diff:

Revision 2 (+602)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/pages/integration.less
	reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
	reviewboard/static/rb/js/integrations/views/integrationManagerView.js
	reviewboard/templates/admin/base_site.html
	reviewboard/templates/integrations/configure_integration.html
	reviewboard/templates/integrations/integration_list.html

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js



Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js

Diff:

Revision 3 (+602)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/pages/integration.less
	reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
	reviewboard/static/rb/js/integrations/views/integrationManagerView.js
	reviewboard/templates/admin/base_site.html
	reviewboard/templates/integrations/configure_integration.html
	reviewboard/templates/integrations/integration_list.html

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js



Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js

Code looks good! Just a few typos in the doc strings

reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 3)
The issue has been resolved. Show all issues
```
"Respresents"
Also, maybe capitalize integration
```
reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 3)
The issue has been resolved. Show all issues
```
"... an integration class"
```
reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 3)
The issue has been resolved. Show all issues
```
maybe get rid of the first "the"
```
reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 3)
The issue has been resolved. Show all issues
```
maybe reword to:
"... ConfiguredIntegration object, which provides enabling or disabling of the instance."
```
reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 3)
The issue has been resolved. Show all issues
```
provides (with an s)
```
reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 3)
The issue has been resolved. Show all issues
```
provides (with an s)
```
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Maybe capitalize integration
```
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3)
The issue has been resolved. Show all issues
```
"It will also provide a link to create a new instance of this"
```
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3)
The issue has been resolved. Show all issues
```
"This will load a configured..."
```
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3)
The issue has been resolved. Show all issues
```
"...objects that belong to..."
```
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3)
The issue has been resolved. Show all issues
```
"Displays a configured integration in a Manage Integration list."
```
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3)
The issue has been resolved. Show all issues
```
will with two l's
"...deleting of the instance."
```
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3)
The issue has been resolved. Show all issues
```
"This destroys..." "... by calling HTTP DLETE..."
```
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 3)
The issue has been resolved. Show all issues
```
destroy typo
```

Change Summary:

Update the description

Description:

~		This provides the backbone model and admin page to manage all the integration.
	~	The integration admin page provides a single interface to manage all the configured integrations. Admmin user can add, delete, change or toggle the state of the integration through this interface. On this page, the admin user will get to see all the configured integrations within the user's permission settings. Each of these integrations will be group according to their integration type, with a simple description and possible actions.

~		Update: March 23, 2015
	~	All of the interaction are achieved through the backbone model, which relies on the integration WebApiResource.
-
-		Added the latest design for the admin page.

Change Summary:

Fix comments for various methods

Diff:

Revision 4 (+602)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/pages/integration.less
	reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
	reviewboard/static/rb/js/integrations/views/integrationManagerView.js
	reviewboard/templates/admin/base_site.html
	reviewboard/templates/integrations/configure_integration.html
	reviewboard/templates/integrations/integration_list.html

Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js

Diff:

Revision 5 (+602)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/pages/integration.less
	reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
	reviewboard/static/rb/js/integrations/views/integrationManagerView.js
	reviewboard/templates/admin/base_site.html
	reviewboard/templates/integrations/configure_integration.html
	reviewboard/templates/integrations/integration_list.html

Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js

Diff:

Revision 6 (+602)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/pages/integration.less
	reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
	reviewboard/static/rb/js/integrations/views/integrationManagerView.js
	reviewboard/templates/admin/base_site.html
	reviewboard/templates/integrations/configure_integration.html
	reviewboard/templates/integrations/integration_list.html

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js



Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js

Change Summary:

Clean up css

Diff:

Revision 7 (+598)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/pages/integration.less
	reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
	reviewboard/static/rb/js/integrations/views/integrationManagerView.js
	reviewboard/templates/admin/base_site.html
	reviewboard/templates/integrations/configure_integration.html
	reviewboard/templates/integrations/integration_list.html

Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js

Fix it!

reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 7)
An issue was opened. Show all issues
```
This should use RB.BaseResource, which handles URLs, parsing, etc.
```

reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 7)

An issue was opened. Show all issues

I doubt we want to append another period--all the error strings in webapi/errors.py have text that ends in a period.

reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 7)

An issue was opened. Show all issues

I doubt we want to append another period--all the error strings in webapi/errors.py have text that ends in a period.

reviewboard/static/rb/js/integrations/models/integrationManagerModel.js (Diff revision 7)
An issue was opened. Show all issues
```
This should use RB.BaseResource, which handles URLs, parsing, etc.
```
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 7)
An issue was opened. Show all issues
```
The "Add" text should be passed in as a variable, and run through gettext().
```
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 7)
An issue was opened. Show all issues
```
This text should be passed in and run through gettext().
```
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 7)
An issue was opened. Show all issues
```
This text should be run through gettext().
```
reviewboard/static/rb/js/integrations/views/integrationManagerView.js (Diff revision 7)
An issue was opened. Show all issues
```
We shouldn't add another period.
```

Status: Discarded

Change Summary:

Closed in favor of a revised version of Integrations that landed for 3.0.