-
-
-
-
-
-
-
checklist/checklist/resources/checklist_template.py (Diff revision 1) Col: 1 E302 expected 2 blank lines, found 1
-
checklist/checklist/resources/checklist_template.py (Diff revision 1) undefined name 'ObjectDoesNotExist'
-
checklist/checklist/resources/checklist_template.py (Diff revision 1) undefined name 'DOES_NOT_EXIST'
[checklist] Implement checklist templates in account pages
Review Request #7099 — Created March 21, 2015 and submitted
An additional functionality of the checklist extension is to allow users to create individual templates which can be quickly added to any existing checklists. This change does not enable checklist templates to be imported into existing checklists.
Checklist templates are stored with two attributes, their title as a string and their list of items in JSON format.
The form for users to modify their checklist templates is under their account preferences page. In the form, users can add checklist templates, remove checklist templates, or edit an existing checklist template.
The form will automatically add new item fields when it detects that the user is editing the last item field, or when the user presses enter.
On Chrome 41.0.2272 and Safari 8.0.2:
- Basic CRUD functionality - adding, editing and removing - works as it should.
- Does not accept templates without a title.
- Empty items are not included upon form submission.
- Tested and ensured that the UI shortcuts (enter, tab) work.
- Verified that the issue where the menu entry will disappear has been resolved (after #7103).
- Ensured that users can only view and edit their own templates.
| Description | From | Last Updated |
|---|---|---|
|
'AccountPageFormsHook' imported but unused |
 reviewbot
|
|
|
Col: 50 E231 missing whitespace after ',' |
reviewbot
|
|
|
Col: 56 E231 missing whitespace after ',' |
reviewbot
|
|
|
Col: 80 E501 line too long (83 > 79 characters) |
reviewbot
|
|
|
Col: 1 W391 blank line at end of file |
reviewbot
|
|
|
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
undefined name 'ObjectDoesNotExist' |
reviewbot
|
|
|
undefined name 'DOES_NOT_EXIST' |
reviewbot
|
|
|
undefined name 'webapi_response_errors' |
reviewbot
|
|
|
Two blank lines here |
XU xuanyi | |
|
Two blank lines over here. |
XU xuanyi | |
|
Two blank lines here. |
XU xuanyi | |
|
Two blank lines here. |
XU xuanyi | |
|
Two blank lines here. |
XU xuanyi | |
|
Two blank lines here. |
XU xuanyi | |
|
Two blank lines here. |
XU xuanyi | |
|
No blank line here (django, djblets, and reviewboard are all "3rd party" from checklist's perspective). |
 david
|
|
|
No blank line here (django, djblets, and reviewboard are all "3rd party" from checklist's perspective). |
david
|
|
|
These can also be chained, eliminating the need to define $itemLi (which seems to be missing a var statement anyway): … |
david
|
|
|
These can be chained: this.$el .hide() .before(editView.$el); |
david
|
|
|
In javascript, a trailing comma on the last entry in an array or object can break on some browsers. |
david
|
|
|
We generally use _$ instead of $_ for internal jquery variables. |
david
|
|
|
In javascript, a trailing comma on the last entry in an array or object can break on some browsers. |
david
|
|
|
This needs to independently test keyCode against ENTER and 13. Right now this evaluates to only testing against ENTER: if … |
david
|
SU
Change Summary:
Fix Review Bot issues.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+584 -14) |
-
Tool: Pyflakes Processed Files: checklist/checklist/models.py checklist/checklist/resources/checklist_template.py checklist/checklist/extension.py checklist/checklist/resources/checklist.py Ignored Files: checklist/checklist/static/css/accountpage.less checklist/checklist/static/js/models/checklistTemplate.js checklist/checklist/static/js/views/checklistAccountPageView.js Tool: PEP8 Style Checker Processed Files: checklist/checklist/models.py checklist/checklist/resources/checklist_template.py checklist/checklist/extension.py checklist/checklist/resources/checklist.py Ignored Files: checklist/checklist/static/css/accountpage.less checklist/checklist/static/js/models/checklistTemplate.js checklist/checklist/static/js/views/checklistAccountPageView.js -
checklist/checklist/resources/checklist_template.py (Diff revision 2) undefined name 'webapi_response_errors'
SU
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+585 -14) |
-
Tool: Pyflakes Processed Files: checklist/checklist/models.py checklist/checklist/resources/checklist_template.py checklist/checklist/extension.py checklist/checklist/resources/checklist.py Ignored Files: checklist/checklist/static/css/accountpage.less checklist/checklist/static/js/models/checklistTemplate.js checklist/checklist/static/js/views/checklistAccountPageView.js Tool: PEP8 Style Checker Processed Files: checklist/checklist/models.py checklist/checklist/resources/checklist_template.py checklist/checklist/extension.py checklist/checklist/resources/checklist.py Ignored Files: checklist/checklist/static/css/accountpage.less checklist/checklist/static/js/models/checklistTemplate.js checklist/checklist/static/js/views/checklistAccountPageView.js
SU
Change Summary:
Removed [WIP] after #7103.
Summary: |
|
|||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||||||||
Testing Done: |
|
|||||||||||||||||||||||||||||||||
Depends On: |
|
SU
Change Summary:
Add init.py imports.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+590 -14) |
-
Tool: Pyflakes Processed Files: checklist/checklist/models.py checklist/checklist/resources/checklist_template.py checklist/checklist/extension.py checklist/checklist/resources/__init__.py checklist/checklist/resources/checklist_resource.py Ignored Files: checklist/checklist/static/css/accountpage.less checklist/checklist/static/js/models/checklistTemplate.js checklist/checklist/static/js/views/checklistAccountPageView.js Tool: PEP8 Style Checker Processed Files: checklist/checklist/models.py checklist/checklist/resources/checklist_template.py checklist/checklist/extension.py checklist/checklist/resources/__init__.py checklist/checklist/resources/checklist_resource.py Ignored Files: checklist/checklist/static/css/accountpage.less checklist/checklist/static/js/models/checklistTemplate.js checklist/checklist/static/js/views/checklistAccountPageView.js
SU
Change Summary:
Found a bug where templates that do not belong to the user are shown.
Summary: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
SU
Change Summary:
Fixed the bug where templates that do not belong to the user are shown.
Summary: |
|
||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
||||||||||||||||||||||||||||||||||||
Commit: |
|
||||||||||||||||||||||||||||||||||||
Diff: |
Revision 5 (+596 -14) |
-
Tool: PEP8 Style Checker Processed Files: checklist/checklist/models.py checklist/checklist/resources/checklist_template.py checklist/checklist/extension.py checklist/checklist/resources/__init__.py checklist/checklist/resources/checklist_resource.py Ignored Files: checklist/checklist/static/css/accountpage.less checklist/checklist/static/js/models/checklistTemplate.js checklist/checklist/static/js/views/checklistAccountPageView.js Tool: Pyflakes Processed Files: checklist/checklist/models.py checklist/checklist/resources/checklist_template.py checklist/checklist/extension.py checklist/checklist/resources/__init__.py checklist/checklist/resources/checklist_resource.py Ignored Files: checklist/checklist/static/css/accountpage.less checklist/checklist/static/js/models/checklistTemplate.js checklist/checklist/static/js/views/checklistAccountPageView.js
XU
-
-
-
checklist/checklist/static/js/models/checklistTemplate.js (Diff revision 5) Two blank lines over here.
-
-
checklist/checklist/static/js/views/checklistAccountPageView.js (Diff revision 5) Two blank lines here.
-
checklist/checklist/static/js/views/checklistAccountPageView.js (Diff revision 5) Two blank lines here.
-
checklist/checklist/static/js/views/checklistAccountPageView.js (Diff revision 5) Two blank lines here.
-
checklist/checklist/static/js/views/checklistAccountPageView.js (Diff revision 5) Two blank lines here.
SU
Change Summary:
Fixed line breaks and semi-colon.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 6 (+606 -17) |
-
Tool: PEP8 Style Checker Processed Files: checklist/checklist/models.py checklist/checklist/resources/checklist_template.py checklist/checklist/extension.py checklist/checklist/resources/__init__.py checklist/checklist/resources/checklist_resource.py Ignored Files: checklist/checklist/static/css/accountpage.less checklist/checklist/static/js/models/checklistTemplate.js checklist/checklist/static/js/views/checklistAccountPageView.js Tool: Pyflakes Processed Files: checklist/checklist/models.py checklist/checklist/resources/checklist_template.py checklist/checklist/extension.py checklist/checklist/resources/__init__.py checklist/checklist/resources/checklist_resource.py Ignored Files: checklist/checklist/static/css/accountpage.less checklist/checklist/static/js/models/checklistTemplate.js checklist/checklist/static/js/views/checklistAccountPageView.js
-
-
checklist/checklist/resources/checklist_resource.py (Diff revision 6) No blank line here (django, djblets, and reviewboard are all "3rd party" from checklist's perspective).
-
checklist/checklist/resources/checklist_template.py (Diff revision 6) No blank line here (django, djblets, and reviewboard are all "3rd party" from checklist's perspective).
-
checklist/checklist/static/js/views/checklistAccountPageView.js (Diff revision 6) These can also be chained, eliminating the need to define
$itemLi(which seems to be missing avarstatement anyway):$('<li class="rbchecklist-template-item" />') .text(item) .appendTo($items); -
checklist/checklist/static/js/views/checklistAccountPageView.js (Diff revision 6) These can be chained:
this.$el .hide() .before(editView.$el); -
checklist/checklist/static/js/views/checklistAccountPageView.js (Diff revision 6) In javascript, a trailing comma on the last entry in an array or object can break on some browsers.
-
checklist/checklist/static/js/views/checklistAccountPageView.js (Diff revision 6) We generally use
_$instead of$_for internal jquery variables. -
checklist/checklist/static/js/views/checklistAccountPageView.js (Diff revision 6) In javascript, a trailing comma on the last entry in an array or object can break on some browsers.
-
checklist/checklist/static/js/views/checklistAccountPageView.js (Diff revision 6) This needs to independently test
keyCodeagainstENTERand13. Right now this evaluates to only testing againstENTER:if (event.keyCode === $.ui.keyCode.ENTER || event.keyCode === 13) {
SU
Change Summary:
Add docs and fix syntax.
Now focuses on the title field upon adding a new template.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 7 (+617 -17) |
-
Tool: PEP8 Style Checker Processed Files: checklist/checklist/models.py checklist/checklist/resources/checklist_template.py checklist/checklist/extension.py checklist/checklist/resources/__init__.py checklist/checklist/resources/checklist_resource.py Ignored Files: checklist/checklist/static/css/accountpage.less checklist/checklist/static/js/models/checklistTemplate.js checklist/checklist/static/js/views/checklistAccountPageView.js Tool: Pyflakes Processed Files: checklist/checklist/models.py checklist/checklist/resources/checklist_template.py checklist/checklist/extension.py checklist/checklist/resources/__init__.py checklist/checklist/resources/checklist_resource.py Ignored Files: checklist/checklist/static/css/accountpage.less checklist/checklist/static/js/models/checklistTemplate.js checklist/checklist/static/js/views/checklistAccountPageView.js
Tool: PEP8 Style Checker Processed Files: checklist/checklist/models.py checklist/checklist/resources/checklist_template.py checklist/checklist/extension.py checklist/checklist/resources/checklist.py Ignored Files: checklist/checklist/static/css/accountpage.less checklist/checklist/static/js/models/checklistTemplate.js checklist/checklist/static/js/views/checklistAccountPageView.js Tool: Pyflakes Processed Files: checklist/checklist/models.py checklist/checklist/resources/checklist_template.py checklist/checklist/extension.py checklist/checklist/resources/checklist.py Ignored Files: checklist/checklist/static/css/accountpage.less checklist/checklist/static/js/models/checklistTemplate.js checklist/checklist/static/js/views/checklistAccountPageView.js