Add a commit selector view.
Review Request #4322 — Created July 11, 2013 and submitted
Add a commit selector view. This is used by the new new review request UI for creating requests from committed revisions. This handles the basic functionality of displaying a list of commits and triggering a 'create' event when one is clicked (or navigating to the review request if one already exists). There's a little bit more on my todo list for this, namely: - Providing some visual indication when there's already a review request. - Using the API pagination to provide infinite scroll.
Used this in my post-commit UI.
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/commitView.js reviewboard/static/rb/js/newReviewRequest/views/commitsView.js
-
-
-
reviewboard/static/rb/js/newReviewRequest/views/commitView.js (Diff revision 1) Should be able to just put this in the events table.
-
reviewboard/static/rb/js/newReviewRequest/views/commitView.js (Diff revision 1) Can you document all the functions in these files?
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/commitView.js reviewboard/static/rb/js/newReviewRequest/views/commitsView.js
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/commitView.js reviewboard/static/rb/js/newReviewRequest/views/commitsView.js