Summary

Extensions' 'config/' and 'db/' admin links don't work when SITE_ROOT isn't '/'

Review Request #3874 — Created Feb. 16, 2013 and submitted Feb. 18, 2013, 2:08 a.m.

Information

Owner

rajasaur

Repository

Djblets

Branch

Bugs

2843

Depends On

Reviewers

Groups

djblets

People

Description

Fix admin-urls for extensions when SITE_ROOT != '/'

In the case of custom SITE_ROOTs, the calculation of the extensions' 'db/' and 'config/' seem to use the reverse function for extension_list method and then append it to the DynamicUrlResolvers' add_patterns method. This adds an additional SITE_ROOT pattern as reverse(extension_list) itself returns the path with the SITE_ROOT. So, instead of the url for SITE_ROOT='/reviews/' being

reviews/admin/extensions/rbcustomreports.extension.CustomReportsExtension/config/
it turns out to be
reviews/reviews/admin/extensions/rbcustomreports.extension.CustomReportsExtension/config/

Fixed this by lstrip-ing the SITE_ROOT after getting a reverse function so that dynamic url resolver adds it properly. This should work for SITE_ROOT='/' or custom SITE_ROOTs.

Testing Done

Tested with SITE_ROOT='/' and SITE_ROOT='/reviews/', installed an extension and testing the "Configure" link.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    djblets/extensions/base.py
  Ignored Files:

Ship it!

```
Looks good to me.
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (8515309)