-
-
rbtools/commands/rb.py (Diff revision 1) I think it's fine to just call pkg_resources.get_entry_map directly where it's needed. I don't see any other cases where this function is used.
-
-
rbtools/commands/rb.py (Diff revision 1) You can just do: if command_name not in commands: It prevents having to build a list of keys.
-
rb --help now displays all available commands.
Review Request #3690 — Created Dec. 20, 2012 and discarded
rb --help now displays all available commands. And the error message on invalid commands is somewhat easier to understand. Note that I just thought that this feature was useful, but I am definitely OK if you don't want to implement it, or if you want to implement it your way down the road. Just discard the request, no problem.
Tested manually with valid and invalid command names.
| Description | From | Last Updated |
|---|---|---|
|
I think it's fine to just call pkg_resources.get_entry_map directly where it's needed. I don't see any other cases where this … |
 chipx86
|
|
|
No space before : |
chipx86
|
|
|
You can just do: if command_name not in commands: It prevents having to build a list of keys. |
chipx86
|
|
|
No space before : |
chipx86
|
SM
-
I have a review request up now which is doing something similar, but we will be moving away from this down the line.