Summary

RB Patch (webapi modification)

Review Request #3593 — Created Nov. 30, 2012 and submitted Nov. 30, 2012, 12:26 p.m.

Information

Owner

jsintal

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Small change to the DiffSet in DiffResource to expose the 'basedir' to the webapi.
Used for my 'RB Patch' http://reviews.reviewboard.org/r/3440/

Testing Done

Accessed the field on an SVN DiffResource on dev server.

Description:

		Small change to the DiffSet in DiffResource to expose the 'basedir' to the webapi.
~		Used for my 'RB Patch' r/3440.
	~	Used for my 'RB Patch' http://reviews.reviewboard.org/r/3440/

Change Summary:

I rebased my branch of master on an updated master. Nothing else has changed except being more up to date.

Diff:

Revision 2 (+9)

Show changes

reviewboard/webapi/resources.py

Ship it!

So the code looks fine, but the summary and description really should be talking about this change, not your other change. For future changes, try to make the summary and description very clear so we can more easily scan our dashboard and know what it's about.

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (affb896)