Navigation and action hooks missing extension parameter

 






 

 


  Review Request #2839
  —
  Created Jan. 31, 2012 and submitted 

 


















 

  

   Information

  





 
 

  bartek
 









 
 

  Review Board
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
I am not very fluent in extensions yet however it looks like a bug to me that the ExtensionHook class does not receive extension instance. Please check and discard if not an issue. I was able to use the action hooks properly after this change.

The setup.py change was published by accident, however it fixes the issue with pip install.

 








  


 
 

  
Action hook available and working in a similar fashion as dashboard hook.

 







 









 





  








 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
What are these changes for?

      		
      
       chipx86chipx86
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      setup.py
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    What are these changes for?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      pip install fails without it.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I still don't understand why you need this. If you don't change the import, you wouldn't need to change the uses.
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      Yes, the change doesn't change anything from the logical point of view. However I am now able to install the ReviewBoard using 'pip install' command which wasn't possible before the change.
      
 
      

      4. 



    4. 
 
 
      
 
      
  
 
      
 
      
  
      That doesn't really make any sense. It's the same import.

It's also completely separate from the other change. I'd prefer this change just be about the extension parameter, and this goes up separately for discussion and analysis.
      
 
      

      5. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   





 BA





   

   

  

 



 















 





 

  

   




mike_conley




   

   





  

 



 

  


   

   

    
 
mike_conley


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Hey Bartek,

It looks like your latest patch isn't applying cleanly - I can't seem to view your code.

-Mike
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Should I pull/rebase my changes and update the review to fix this? I will do that anyway. Please let me know if that's not the case.
      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 BA





   

   

  

 



 















 



 

  

   





 BA





   

   

  

 



 















 





 

  

   




mike_conley




   

   







  

 



 

  


   

   

    
 
mike_conley


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Bartek:

Thanks for catching this - yep, I'm pretty sure this was a mistake on our part.

Good work,

-Mike
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 BA





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Committed to master as 870e777b.  Thanks!





 


 










  

 









     

    

   

  

  

   
   Loading...