Summary

Use Django's smarter if tag.

Review Request #2834 — Created Jan. 29, 2012 and submitted Feb. 18, 2012, 5:14 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Use Django's smarter if tag.

Django these days provides a smarter if tag that allows for basic
expressions. This is nicer than using ifequal for things, and with
Django 1.4, we can also do elif. This cleans up bits of the code and
allows some expressions and nested ifs to be condensed.

Testing Done

I checked a few pages, but haven't checked everything. I'd like a pair
of eyes on every line of my change to be sure I didn't do something
stupid. We'll also want to just test this a lot before beta.

Issues

Description	From	Last Updated
Not 100% sure, but I think this comment can now be removed.	ME medanat	Feb. 18, 2012, 5:12 p.m.
Why is this line commented out?	ME medanat	Feb. 18, 2012, 5:12 p.m.
One less indent here.	ME medanat	Feb. 18, 2012, 5:10 p.m.
One less indent here.	ME medanat	Feb. 18, 2012, 5:10 p.m.
One less indent for both of these lines.	ME medanat	Feb. 18, 2012, 5:10 p.m.
One less indent here.	ME medanat	Feb. 18, 2012, 5:11 p.m.
One less indent here.	ME medanat	Feb. 18, 2012, 5:11 p.m.
Insert one indent here.	ME medanat	Feb. 18, 2012, 5:11 p.m.
Insert one indent here.	ME medanat	Feb. 18, 2012, 5:11 p.m.
single space after added_by. i.e.: added_by %}	ME medanat	Feb. 18, 2012, 5:12 p.m.

The transition seems correct (to me).
I found some indentation style issues while trying to match if statements (mostly from code you didn't alter), but that's minor.

Yazan

reviewboard/templates/reviews/review_header.html (Diff revision 1)
The issue has been resolved. Show all issues
```
One less indent here.
```
reviewboard/templates/reviews/review_header.html (Diff revision 1)
The issue has been resolved. Show all issues
```
One less indent here.
```
reviewboard/templates/reviews/review_header.html (Diff revision 1)
The issue has been resolved. Show all issues
```
One less indent for both of these lines.
```
reviewboard/templates/reviews/review_request_actions_secondary.html (Diff revision 1)
The issue has been resolved. Show all issues
```
One less indent here.
```
reviewboard/templates/reviews/review_request_actions_secondary.html (Diff revision 1)
The issue has been resolved. Show all issues
```
One less indent here.
```
reviewboard/templates/reviews/review_request_actions_secondary.html (Diff revision 1)
The issue has been resolved. Show all issues
```
Insert one indent here.
```
reviewboard/templates/reviews/review_request_actions_secondary.html (Diff revision 1)
The issue has been resolved. Show all issues
```
Insert one indent here.
```

More code maintenance: I don't know if these issues should be brought up in this review, but I can't help but spot them while going through the code.

Yazan

reviewboard/templates/accounts/password_reset.html (Diff revision 1)

The issue has been dropped. Show all issues

Not 100% sure, but I think this comment can now be removed.

chipx86 Feb. 18, 2012, 5:12 p.m.

Yeah, this should be tackled in a separate change. Good catch, though!

reviewboard/templates/reviews/diff_comment_fragment.html (Diff revision 1)
The issue has been dropped. Show all issues
```
Why is this line commented out?
```
1. chipx86 Feb. 18, 2012, 5:12 p.m.
  Hah. Debugging info. Harmless, but yeah, probably could go. Separate change.
reviewboard/templates/reviews/search.html (Diff revision 1)
The issue has been resolved. Show all issues
```
single space after added_by.

i.e.: added_by %}
```

Ship it!

Aside from the style issues that Yazan found, this looks fine to me.

Status: Closed (submitted)

Change Summary:

Pushed to master (b6951bf)