Summary

Update DialogView to use Ink buttons.

Review Request #13844 — Created May 8, 2024 and updated May 16, 2024, 9 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

DialogView now constructs Ink buttons based on the provided button data.
This replaces the old input-type buttons, giving us buttons that work
well in dark mode.

Testing Done

Unit tests passed.

Tested various dialogs based on DialogView in both light and dark
modes.

Commits

Summary	ID
Update DialogView to use Ink buttons. DialogView now constructs Ink buttons based on the provided button data. This replaces the old `input`-type buttons, giving us buttons that work well in dark mode.	57c3c67ec27e47aea6408fc4f538a38a822ad5a0

Files

Issues

Description	From	Last Updated
['disabled'] is better written in dot notation. Column: 28 Error code: W069	reviewbot	May 15, 2024, 11:11 p.m.
['type'] is better written in dot notation. Column: 28 Error code: W069	reviewbot	May 15, 2024, 11:11 p.m.
['type'] is better written in dot notation. Column: 28 Error code: W069	reviewbot	May 15, 2024, 11:11 p.m.
['onClick'] is better written in dot notation. Column: 28 Error code: W069	reviewbot	May 15, 2024, 11:11 p.m.
Missing semicolon. Column: 59 Error code: W033	reviewbot	May 15, 2024, 11:11 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/ui/views/dialogView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
['disabled'] is better written in dot notation.

Column: 28
Error code: W069
```
reviewboard/static/rb/js/ui/views/dialogView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
['type'] is better written in dot notation.

Column: 28
Error code: W069
```
reviewboard/static/rb/js/ui/views/dialogView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
['type'] is better written in dot notation.

Column: 28
Error code: W069
```
reviewboard/static/rb/js/ui/views/dialogView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
['onClick'] is better written in dot notation.

Column: 28
Error code: W069
```
reviewboard/static/rb/js/ui/views/tests/dialogViewTests.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing semicolon.

Column: 59
Error code: W033
```

Change Summary:


Switched to setting attributes by dot notation.
Fixed a missing semicolon.

Commits:

	Summary	ID
	Update DialogView to use Ink buttons. DialogView now constructs Ink buttons based on the provided button data. This replaces the old `input`-type buttons, giving us buttons that work well in dark mode.	478282f509e62046d9d0873394a390ba8802c527
	Update DialogView to use Ink buttons. DialogView now constructs Ink buttons based on the provided button data. This replaces the old `input`-type buttons, giving us buttons that work well in dark mode.	57c3c67ec27e47aea6408fc4f538a38a822ad5a0

Diff:

Revision 2 (+84 -74)

Show changes

	reviewboard/static/rb/js/ui/views/dialogView.es6.js
	reviewboard/static/rb/js/ui/views/tests/dialogViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```