Summary

Update Ink spacing usage for the new adjustments.

Review Request #13828 — Created May 6, 2024 and submitted May 8, 2024, 10:58 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Ink's spacing tokens have been updated to be based on a medium=1em
scaling, and with all sizes above m being updated to be far more
useful for layout.

This impacted a few places in the UI: Banners, trophies, and issue bars.
This change fixes those up, using more appropriate tokens and ensuring
layout looks correct.

Testing Done

Grepped the codebase for usage of the affected units. Checked and updated
what I saw.

There may be further changes as we work on the codebase.

Commits

Summary	ID
Update Ink spacing usage for the new adjustments. Ink's spacing tokens have been updated to be based on a medium=1em scaling, and with all sizes above `m` being updated to be far more useful for layout. This impacted a few places in the UI: Banners, trophies, and issue bars. This change fixes those up, using more appropriate tokens and ensuring layout looks correct.	3e4433fbaa993433017675a4cadc7a8840e41fb6

Files

Issues

Description	From	Last Updated
Can we align the top of the drop-down with the bottom of the banner? This is pretty stair-steppy.	david	May 8, 2024, 3:40 p.m.

flake8 passed.

JSHint passed.

Unified banner (Revision 1)

The issue has been dropped. Show all issues

Can we align the top of the drop-down with the bottom of the banner? This is pretty stair-steppy.

chipx86 May 7, 2024, 10:08 p.m.

Turns out this wasn't a regression in this change, but likely in my original Ink work for the banner. I'll track this and look into it separately as polish.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (4a86ddb)