Convert ExtensionManagerView to TypeScript/spina and fix bundles.
Review Request #13803 — Created April 30, 2024 and submitted
This change converts the ExtensionManagerView class to TypeScript and
spina.This also fixes up some issues with our bundles in djblets. The
ExtensionManagerModel was converted to TypeScript, but inadvertently
included in the djblets-extensions bundle instead of the
djblets-extensions-admin bundle. In addition, we had neglected to remove
the other old filenames for the rest of the djblets-extensions bundle
contents from the list.
- Ran js-tests.
- Used the extensions list in the Review Board admin and saw everything
work correctly.
Summary | ID |
---|---|
e3c7d6959f98003c82eb2580a2a3a8eb55e1c518 |
Description | From | Last Updated |
---|---|---|
Extra word here: "in" |
maubin | |
Did you mean Djblets 6? |
maubin | |
Trailing comma here. |
chipx86 | |
Shouldn't need to use super anymore, since that should auto-merge. (Check to be sure.) |
chipx86 | |
It'd be nice to avoid having a newline here. Can we instead just set the value on the next line, … |
chipx86 | |
This is used to customize the classes in use by the parent, so they can be specialized. We need to … |
chipx86 | |
Should be protected. |
chipx86 |
-
-
djblets/static/djblets/js/extensionsAdmin/views/extensionManagerView.ts (Diff revision 1) Extra word here: "in"
-
djblets/static/djblets/js/extensionsAdmin/views/extensionManagerView.ts (Diff revision 1) Did you mean Djblets 6?
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+204 -134) |
Checks run (2 succeeded)
-
-
-
djblets/static/djblets/js/extensionsAdmin/views/extensionManagerView.ts (Diff revision 2) Shouldn't need to use
super
anymore, since that should auto-merge. (Check to be sure.) -
djblets/static/djblets/js/extensionsAdmin/views/extensionManagerView.ts (Diff revision 2) It'd be nice to avoid having a newline here. Can we instead just set the value on the next line, the way we had it before?
-
djblets/static/djblets/js/extensionsAdmin/views/extensionManagerView.ts (Diff revision 2) This is used to customize the classes in use by the parent, so they can be specialized. We need to keep these and keep all the references below.
It'd also make sense to have
ExtensionManagerView
take these as generics, so there's enforcement of types. -
djblets/static/djblets/js/extensionsAdmin/views/extensionManagerView.ts (Diff revision 2) Should be
protected
.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+200 -134) |