Change element classes for inline editors.

 






 

 


  Review Request #13780
  —
  Created April 24, 2024 and submitted 

 




















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
When I ported the inline editors to TypeScript, I marked them as being

HTMLDivElement. These aren't always attached to a <div>, so this

change fixed that to just be HTMLElement.

 








  


 
 

  
Saw that I no longer got warnings instantiating an editor for a

<span>.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Change element classes for inline editors.
      
When I ported the inline editors to TypeScript, I marked them as being
`HTMLDivElement`. These aren't always attached to a `<div>`, so this
change fixed that to just be `HTMLElement`.

Testing Done:
Saw that I no longer got warnings instantiating an editor for a
`<span>`.

     


    		
    994457263c8ff47aae424f2cb26756fe81387c0d

   



  
 




 













 









 






  

 



















 




 




 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...