Summary

Fix draft comments on unpublished diffs.

Review Request #13777 — Created April 23, 2024 and submitted April 23, 2024, 10:21 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We weren't including the draft's diffset in the list of all diffsets,
which could cause a KeyError when attempting to compute the comments
hint data when there was a comment on an unpublished draft. This change
fixes that so we include the diffset and all its filediffs in the list
of all diffsets and filediffs.

Testing Done

Reproduced the bug with comments on draft diffs and verified that it no
longer occurred.

Commits

Summary	ID
Fix draft comments on unpublished diffs. We weren't including the draft's diffset in the list of all diffsets, which could cause a KeyError when attempting to compute the comments hint data when there was a comment on an unpublished draft. This change fixes that so we include the diffset and all its filediffs in the list of all diffsets and filediffs. Testing Done: Reproduced the bug with comments on draft diffs and verified that it no longer occurred.	ff1824b1cbe9fdca18c4d0d438d5dac48c635d44

Summary

Fix draft comments on unpublished diffs.

We weren't including the draft's diffset in the list of all diffsets, which could cause a KeyError when attempting to compute the comments hint data when there was a comment on an unpublished draft. This change fixes that so we include the diffset and all its filediffs in the list of all diffsets and filediffs. Testing Done: Reproduced the bug with comments on draft diffs and verified that it no longer occurred.

ff1824b1cbe9fdca18c4d0d438d5dac48c635d44

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (50de7b8)