Summary

Port comments hint view to Ink.Alert

Review Request #13700 — Created April 4, 2024 and submitted April 12, 2024, 12:39 p.m.

Owner

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Groups

People

Description

This change ports the comments hint shown in the diffviewer when a draft
review has comments on other revisions over to the new Ink.Alert
component.

Testing Done

Viewed the comments hint and saw that everything worked correctly.

Commits

Summary	ID
Port comments hint view to Ink.Alert This change ports the comments hint shown in the diffviewer when a draft review has comments on other revisions over to the new Ink.Alert component. Testing Done: Viewed the comments hint and saw that everything worked correctly.	e5c27dba8937533c679e6c78c10dbaf477847e5a

Files

Issues

Description	From	Last Updated
If you choose, you should be able to embed these directly in the template, I believe. Just wrap them in …	chipx86	April 10, 2024, 9:32 a.m.

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/reviews/views/diffCommentsHintView.ts (Diff revision 1)

The issue has been dropped. Show all issues

If you choose, you should be able to embed these directly in the template, I believe. Just wrap them in ${...}.

Though I'm admittedly not 100% sure if that'll be picked up during xgettext.

If there's a gettext() function call in there it will pick them up. That said, I feel like wrapping gets super ugly trying to do that here.

Ship it!

Pushed to release-7.x (5f81685)