Summary

Include Ink as a third-party JavaScript and CSS library.

Review Request #13664 — Created March 25, 2024 and submitted April 1, 2024, 7:01 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Since Ink is not released, this currently requires some manual setup
during development. .npm-workspaces/ink must be symlinked to the root
of the Ink source tree, followed by npm install. Once we start
releasing builds of Ink, this symlink can be removed (though will be
needed for local development).

We make use of Ink's babel-preset to enable compilation of craft and
paint templates, easing component and element creation.

There's also a path fix to include Djblets from node_modules, rather
than the legacy .djblets symlink, in order to resolve typing issues.

Testing Done

Viewed some pages and verified that both the Ink JavaScript namespace
and Ink default theme CSS variables were available.

Commits

Summary	ID
Include Ink as a third-party JavaScript and CSS library. This brings in Ink, our new CSS/JavaScript component library, embedding the CSS and JavaScript on all pages. Currently it's not used anywhere, but further changes will be moving components over to it. Since Ink is not released, this currently requires some manual setup during development. `.npm-workspaces/ink` must be symlinked to the root of the Ink source tree, followed by `npm install`. Once we start releasing builds of Ink, this symlink can be removed (though will be needed for local development). We make use of Ink's `babel-preset` to enable compilation of `craft` and `paint` templates, easing component and element creation. There's also a path fix to include Djblets from `node_modules`, rather than the legacy `.djblets` symlink, in order to resolve typing issues.	e8cdef5753f9f80f9aba3c3dc0623301b89baf75

Summary

Include Ink as a third-party JavaScript and CSS library.

This brings in Ink, our new CSS/JavaScript component library, embedding the CSS and JavaScript on all pages. Currently it's not used anywhere, but further changes will be moving components over to it. Since Ink is not released, this currently requires some manual setup during development. `.npm-workspaces/ink` must be symlinked to the root of the Ink source tree, followed by `npm install`. Once we start releasing builds of Ink, this symlink can be removed (though will be needed for local development). We make use of Ink's `babel-preset` to enable compilation of `craft` and `paint` templates, easing component and element creation. There's also a path fix to include Djblets from `node_modules`, rather than the legacy `.djblets` symlink, in order to resolve typing issues.

e8cdef5753f9f80f9aba3c3dc0623301b89baf75

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:


Fixed path issues for Djblets typing.
Moved the Ink externals/globals into the Review Board consumer definition and not Common definition, to avoid issues with the 3rdparty bundle.
Added usage of Ink's babel-preset for craft/paint compilation.

Description:

		This brings in Ink, our new CSS/JavaScript component library, embedding
		the CSS and JavaScript on all pages. Currently it's not used anywhere,
		but further changes will be moving components over to it.

		Since Ink is not released, this currently requires some manual setup
		during development. `.npm-workspaces/ink` must be symlinked to the root
		of the Ink source tree, followed by `npm install`. Once we start
		releasing builds of Ink, this symlink can be removed (though will be
		needed for local development).
	+
	+	We make use of Ink's `babel-preset` to enable compilation of `craft` and
	+	`paint` templates, easing component and element creation.
	+
	+	There's also a path fix to include Djblets from `node_modules`, rather
	+	than the legacy `.djblets` symlink, in order to resolve typing issues.

Commits:

	Summary	ID
	Include Ink as a third-party JavaScript and CSS library. This brings in Ink, our new CSS/JavaScript component library, embedding the CSS and JavaScript on all pages. Currently it's not used anywhere, but further changes will be moving components over to it. Since Ink is not released, this currently requires some manual setup during development. `.npm-workspaces/ink` must be symlinked to the root of the Ink source tree, followed by `npm install`. Once we start releasing builds of Ink, this symlink can be removed (though will be needed for local development).	29103a476fa4262eeb027af4b6baf6745f387644
	Include Ink as a third-party JavaScript and CSS library. This brings in Ink, our new CSS/JavaScript component library, embedding the CSS and JavaScript on all pages. Currently it's not used anywhere, but further changes will be moving components over to it. Since Ink is not released, this currently requires some manual setup during development. `.npm-workspaces/ink` must be symlinked to the root of the Ink source tree, followed by `npm install`. Once we start releasing builds of Ink, this symlink can be removed (though will be needed for local development). We make use of Ink's `babel-preset` to enable compilation of `craft` and `paint` templates, easing component and element creation. There's also a path fix to include Djblets from `node_modules`, rather than the legacy `.djblets` symlink, in order to resolve typing issues.	7878fabd181e451e895a06cf7c14e40bb7032761

Diff:

Revision 2 (+34448 -5972)

Show changes

	package-lock.json
	tsconfig.json
	reviewboard/packaging/js/babel.base.config.json
	reviewboard/packaging/js/rollup-common.mjs
	reviewboard/static/lib/css/3rdparty.less
	reviewboard/static/lib/js/3rdparty/index.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Added the Ink auto stylesheet to the build.

Commits:

	Summary	ID
	Include Ink as a third-party JavaScript and CSS library. This brings in Ink, our new CSS/JavaScript component library, embedding the CSS and JavaScript on all pages. Currently it's not used anywhere, but further changes will be moving components over to it. Since Ink is not released, this currently requires some manual setup during development. `.npm-workspaces/ink` must be symlinked to the root of the Ink source tree, followed by `npm install`. Once we start releasing builds of Ink, this symlink can be removed (though will be needed for local development). We make use of Ink's `babel-preset` to enable compilation of `craft` and `paint` templates, easing component and element creation. There's also a path fix to include Djblets from `node_modules`, rather than the legacy `.djblets` symlink, in order to resolve typing issues.	7878fabd181e451e895a06cf7c14e40bb7032761
	Include Ink as a third-party JavaScript and CSS library. This brings in Ink, our new CSS/JavaScript component library, embedding the CSS and JavaScript on all pages. Currently it's not used anywhere, but further changes will be moving components over to it. Since Ink is not released, this currently requires some manual setup during development. `.npm-workspaces/ink` must be symlinked to the root of the Ink source tree, followed by `npm install`. Once we start releasing builds of Ink, this symlink can be removed (though will be needed for local development). We make use of Ink's `babel-preset` to enable compilation of `craft` and `paint` templates, easing component and element creation. There's also a path fix to include Djblets from `node_modules`, rather than the legacy `.djblets` symlink, in order to resolve typing issues.	e8cdef5753f9f80f9aba3c3dc0623301b89baf75

Diff:

Revision 3 (+18 -14)

Show changes

	reviewboard/packaging/js/babel.base.config.json
	reviewboard/packaging/js/rollup-common.mjs
	reviewboard/static/lib/css/3rdparty.less
	reviewboard/static/lib/js/3rdparty/index.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (85c23fc)