Comment serialization cleanup part 4: Convert DiffFile to TypeScript.
Review Request #13658 — Created March 21, 2024 and submitted
The DiffFile model is quite simple, just being a data storage mechanism
for information about a file in a diff. This file uses a ton of terrible
names for things, and much of the documentation was just flat-out wrong.
This change converts it to TypeScript and spina, and corrects a bunch of
errors in the documentation about the attributes.This also converts the DiffFileCollection class, which is extremely
small.
Ran js-tests.
-
-
reviewboard/static/rb/js/reviews/collections/diffFileCollection.ts (Diff revision 1) Missing
Version Added
(or aVersion Changed
saying where it moved from). -
reviewboard/static/rb/js/reviews/models/diffReviewableModel.ts (Diff revision 1) Should probably be
import type
. -
reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts (Diff revision 1) Should probably be
import type
.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+490 -260) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.