Summary

Make a few improvements to the Mercurial backend.

Review Request #13602 — Created March 4, 2024 and submitted April 1, 2024, 10:35 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change makes a few improvements to our Mercurial support:

The way that binary files were appearing in diffs was causing the
diff parser (based on the GitDiffParser) to override the commit IDs
in the filediff revisions with the file SHAs that hg diff --git was
adding. The file SHAs have no meaning to us, so these have been
replaced back with the commit IDs.
I've started seeing warnings pop up about unclosed resources when
dealing with Popen. Treating the object as a context manager fixes
this.

Testing Done


Ran unit tests.
Posted a bunch of changes, including binary files.

Commits

Summary	ID
Make a few improvements to the Mercurial backend. This change makes a few improvements to our Mercurial support: 1. The way that binary files were appearing in diffs was causing the diff parser (based on the GitDiffParser) to override the commit IDs in the filediff revisions with the file SHAs that `hg diff --git` was adding. The file SHAs have no meaning to us, so these have been replaced back with the commit IDs. 2. I've started seeing warnings pop up about unclosed resources when dealing with Popen. Treating the object as a context manager fixes this. Testing Done: - Ran unit tests. - Posted a bunch of changes, including binary files.	a1aa8fc9e563b325da50f7a60a26ed2938e77764

Summary

Make a few improvements to the Mercurial backend.

This change makes a few improvements to our Mercurial support: 1. The way that binary files were appearing in diffs was causing the diff parser (based on the GitDiffParser) to override the commit IDs in the filediff revisions with the file SHAs that `hg diff --git` was adding. The file SHAs have no meaning to us, so these have been replaced back with the commit IDs. 2. I've started seeing warnings pop up about unclosed resources when dealing with Popen. Treating the object as a context manager fixes this. Testing Done: - Ran unit tests. - Posted a bunch of changes, including binary files.

a1aa8fc9e563b325da50f7a60a26ed2938e77764

Issues

Description	From	Last Updated
Small nit, but: "Mercurial"	chipx86	March 4, 2024, 2:41 p.m.

flake8 passed.

JSHint passed.

Ship it!

reviewboard/scmtools/hg.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Small nit, but: "Mercurial"
```

Commits:

	Summary	ID
	Make a few improvements to the Mercurial backend. This change makes a few improvements to our Mercurial support: 1. The way that binary files were appearing in diffs was causing the diff parser (based on the GitDiffParser) to override the commit IDs in the filediff revisions with the file SHAs that `hg diff --git` was adding. The file SHAs have no meaning to us, so these have been replaced back with the commit IDs. 2. I've started seeing warnings pop up about unclosed resources when dealing with Popen. Treating the object as a context manager fixes this. Testing Done: - Ran unit tests. - Posted a bunch of changes, including binary files.	20492757e93763207175eadf6c4b7754718e1358
	Make a few improvements to the Mercurial backend. This change makes a few improvements to our Mercurial support: 1. The way that binary files were appearing in diffs was causing the diff parser (based on the GitDiffParser) to override the commit IDs in the filediff revisions with the file SHAs that `hg diff --git` was adding. The file SHAs have no meaning to us, so these have been replaced back with the commit IDs. 2. I've started seeing warnings pop up about unclosed resources when dealing with Popen. Treating the object as a context manager fixes this. Testing Done: - Ran unit tests. - Posted a bunch of changes, including binary files.	a1aa8fc9e563b325da50f7a60a26ed2938e77764

Diff:

Revision 2 (+130 -104)

Show changes

reviewboard/scmtools/hg.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (3eee397)

reviewboard/scmtools/hg.py (Diff revision 1)