Summary

Make a bunch of improvements to the FileAttachment admin list.

Review Request #13576 — Created Feb. 27, 2024 and submitted March 7, 2024, 9:12 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The way attachments were listed in the admin site was very difficult to
use. The file field was linking to the download URL, and the only
other link to the change page was the caption, which could be empty.

This change improves the admin list so that the filename rather than the
path is listed (potentially cropped to preserve the page with), but that
always links to the change page. The "Review Request ID" column now
properly shows the linked review request even when the attachment is
part of a draft or in the inactive list. A new column has been added
with the download link.

Testing Done

Used the admin list and was actually able to get to the change page for
many of my attachments.

Commits

Summary	ID
Make a bunch of improvements to the FileAttachment admin list. The way attachments were listed in the admin site was very difficult to use. The `file` field was linking to the download URL, and the only other link to the change page was the caption, which could be empty. This change improves the admin list so that the filename rather than the path is listed (potentially cropped to preserve the page with), but that always links to the change page. The "Review Request ID" column now properly shows the linked review request even when the attachment is part of a draft or in the inactive list. A new column has been added with the download link. Testing Done: Used the admin list and was actually able to get to the change page for many of my attachments.	723e62158186e54d2f2e9cfc94b35d6d00a52e54

Summary

Make a bunch of improvements to the FileAttachment admin list.

The way attachments were listed in the admin site was very difficult to use. The `file` field was linking to the download URL, and the only other link to the change page was the caption, which could be empty. This change improves the admin list so that the filename rather than the path is listed (potentially cropped to preserve the page with), but that always links to the change page. The "Review Request ID" column now properly shows the linked review request even when the attachment is part of a draft or in the inactive list. A new column has been added with the download link. Testing Done: Used the admin list and was actually able to get to the change page for many of my attachments.

723e62158186e54d2f2e9cfc94b35d6d00a52e54

Issues

Description	From	Last Updated
We should move to the new form for this: @admin.display( short_description=... )	chipx86	March 4, 2024, 6:53 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/attachments/admin.py (Diff revision 1)

The issue has been resolved. Show all issues

We should move to the new form for this:

@admin.display(
    short_description=...
)

chipx86 March 4, 2024, 6:21 p.m.
```
Actually, description=
```

Commits:

	Summary	ID
	Make a bunch of improvements to the FileAttachment admin list. The way attachments were listed in the admin site was very difficult to use. The `file` field was linking to the download URL, and the only other link to the change page was the caption, which could be empty. This change improves the admin list so that the filename rather than the path is listed (potentially cropped to preserve the page with), but that always links to the change page. The "Review Request ID" column now properly shows the linked review request even when the attachment is part of a draft or in the inactive list. A new column has been added with the download link. Testing Done: Used the admin list and was actually able to get to the change page for many of my attachments.	120c4977ea649e4a9f1c2ac0f9fae108fd623252
	Make a bunch of improvements to the FileAttachment admin list. The way attachments were listed in the admin site was very difficult to use. The `file` field was linking to the download URL, and the only other link to the change page was the caption, which could be empty. This change improves the admin list so that the filename rather than the path is listed (potentially cropped to preserve the page with), but that always links to the change page. The "Review Request ID" column now properly shows the linked review request even when the attachment is part of a draft or in the inactive list. A new column has been added with the download link. Testing Done: Used the admin list and was actually able to get to the change page for many of my attachments.	723e62158186e54d2f2e9cfc94b35d6d00a52e54

Diff:

Revision 2 (+122 -14)

Show changes

reviewboard/attachments/admin.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (7b45df7)