Convert reviewable models to TypeScript/spina.
Review Request #13530 — Created Feb. 7, 2024 and submitted
This change converts the *Reviewable models to TypeScript. While I was
in here I also removed some deprecated callbacks-style invocation inside
of the DiffReviewable.
- Ran js-tests.
- Smoke tested reviewing file attachments and diffs.
Summary | ID |
---|---|
c7a3bf9643eb23324ba35e369d6cf71709403b4f |
Description | From | Last Updated |
---|---|---|
These should all be removed. |
chipx86 | |
Missing docs. |
chipx86 | |
I think we can infer this type by doing: class AbstractReviewable< TAttributes extends AbstractReviewableAttrs = AbstractReviewableAttrs, TCommentBlockType extends AbstractCommentBlock<TCommentBlockAttrs>, TCommentBlockAttrs … |
chipx86 | |
Two blank lines. |
chipx86 |
-
-
reviewboard/static/rb/js/reviews/models/diffReviewableModel.ts (Diff revision 1) These should all be removed.
-
-
reviewboard/static/rb/js/reviews/models/abstractReviewableModel.ts (Diff revision 1) I think we can infer this type by doing:
class AbstractReviewable< TAttributes extends AbstractReviewableAttrs = AbstractReviewableAttrs, TCommentBlockType extends AbstractCommentBlock<TCommentBlockAttrs>, TCommentBlockAttrs > extends ... { createCommentBlock(attrs: TCommentBlockAttrs) { ... } }
-
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1166 -870) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.