Summary

Fix creating diffs for UCM activities whose changes are in other VOBs.

Review Request #12894 — Created March 15, 2023 and submitted March 17, 2023, 2:01 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Testing Done

Posted a UCM activity where all of the changes existed in a VOB other than the
one in my CWD. Before this change, I was getting an error executing cleartool.
After, the diff is posted successfully.

Commits

Summary	ID
Fix creating diffs for UCM activities whose changes are in other VOBs. One of our more recent changes to improve the versioning of elements in ClearCase/VersionVault introduced a problem where if the element was not inside the same VOB as the CWD, we'd hit an error trying to query for its version. This change adds the VOB UUID as a part of the path that we query, allowing this to work across VOBs. Testing Done: Posted a UCM activity where all of the changes existed in a VOB other than the one in my CWD. Before this change, I was getting an error executing cleartool. After, the diff is posted successfully.	ebb42f7c7ce3efa6ce0b835a26d1752999bf3525

Summary

Fix creating diffs for UCM activities whose changes are in other VOBs.

One of our more recent changes to improve the versioning of elements in ClearCase/VersionVault introduced a problem where if the element was not inside the same VOB as the CWD, we'd hit an error trying to query for its version. This change adds the VOB UUID as a part of the path that we query, allowing this to work across VOBs. Testing Done: Posted a UCM activity where all of the changes existed in a VOB other than the one in my CWD. Before this change, I was getting an error executing cleartool. After, the diff is posted successfully.

ebb42f7c7ce3efa6ce0b835a26d1752999bf3525

Issues

Description	From	Last Updated
blank line contains whitespace Column: 1 Error code: W293	reviewbot	March 15, 2023, 3:45 p.m.
line too long (87 > 79 characters) Column: 80 Error code: E501	reviewbot	March 15, 2023, 3:45 p.m.
line too long (83 > 79 characters) Column: 80 Error code: E501	reviewbot	March 15, 2023, 3:45 p.m.
line too long (82 > 79 characters) Column: 80 Error code: E501	reviewbot	March 15, 2023, 3:45 p.m.
line too long (87 > 79 characters) Column: 80 Error code: E501	reviewbot	March 15, 2023, 3:46 p.m.
line too long (83 > 79 characters) Column: 80 Error code: E501	reviewbot	March 15, 2023, 3:46 p.m.
line too long (82 > 79 characters) Column: 80 Error code: E501	reviewbot	March 15, 2023, 3:46 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/clearcase.py (Diff revision 1)
The issue has been dropped. Show all issues
```
blank line contains whitespace

Column: 1
Error code: W293
```
rbtools/clients/tests/test_clearcase.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (87 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_clearcase.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (83 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_clearcase.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (82 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Fix creating diffs for UCM activities whose changes are in other VOBs. One of our more recent changes to improve the versioning of elements in ClearCase/VersionVault introduced a problem where if the element was not inside the same VOB as the CWD, we'd hit an error trying to query for its version. This change adds the VOB UUID as a part of the path that we query, allowing this to work across VOBs. Testing Done: Posted a UCM activity where all of the changes existed in a VOB other than the one in my CWD. Before this change, I was getting an error executing cleartool. After, the diff is posted successfully.	053d93eb66760d4ed64f58006cb91e5b7033a5a4
	Fix creating diffs for UCM activities whose changes are in other VOBs. One of our more recent changes to improve the versioning of elements in ClearCase/VersionVault introduced a problem where if the element was not inside the same VOB as the CWD, we'd hit an error trying to query for its version. This change adds the VOB UUID as a part of the path that we query, allowing this to work across VOBs. Testing Done: Posted a UCM activity where all of the changes existed in a VOB other than the one in my CWD. Before this change, I was getting an error executing cleartool. After, the diff is posted successfully.	ebb42f7c7ce3efa6ce0b835a26d1752999bf3525

Diff:

Revision 2 (+102 -40)

Show changes

	rbtools/clients/clearcase.py
	rbtools/clients/tests/test_clearcase.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/clients/tests/test_clearcase.py (Diff revision 2)
The issue has been dropped. Show all issues
```
line too long (87 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_clearcase.py (Diff revision 2)
The issue has been dropped. Show all issues
```
line too long (83 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_clearcase.py (Diff revision 2)
The issue has been dropped. Show all issues
```
line too long (82 > 79 characters)

Column: 80
Error code: E501
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (df83d02)