Update diff functions on all SCMClients and remove client-specific args.

Review Request #12584 — Created Sept. 6, 2022 and submitted

Information

RBTools
release-4.x

Reviewers

We had a lot of inconsistency between diff() function signatures in
SCMClients. Some took only a subset of the arguments. Some took
arguments not defined in BaseSCMClient.diff(). Git had its own
Git-specific argument, --git-find-renames-threshold.

This updates all function signatures to be compatible with the base
function signature.

The Git-specific option has been removed. Instead, GitClient.diff()
now just checks self.options, instead of rbt post and rbt diff
doing this.

Unit tests pass.

Tested rbt diff and rbt post with --git-find-renames-threshold.

Summary ID
Update diff functions on all SCMClients and remove client-specific args.
We had a lot of inconsistency between `diff()` function signatures in SCMClients. Some took only a subset of the arguments. Some took arguments not defined in `BaseSCMClient.diff()`. Git had its own Git-specific argument, `git_find_renames_threshold`. This updates all function signatures to be compatible with the base function signature. The Git-specific option has been removed. Instead, `GitClient.diff()` now just checks `self.options`, instead of `rbt post` and `rbt diff` doing this.
453434e2516e851255b3814f1eadced3fb886776
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.x (9efae51)