Summary

Fix Review Bot extension unit tests on Review Board 3.

Review Request #12454 — Created July 11, 2022 and submitted July 11, 2022, 7:11 p.m.

Information

Owner

chipx86

Repository

ReviewBot

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description

The unit tests for Review Bot were unconditionally importing reverse

from the modern django.urls, which wasn't available on Django 1.6 /

Review Board 3.
They're now updated to fall back on the older import from

django.core.urlresolvers, allowing tests to run on Review Board 3.

Testing Done

Unit tests pass on Review Board 3, 4, and 5.

Commits

Summary	ID
Fix Review Bot extension unit tests on Review Board 3. The unit tests for Review Bot were unconditionally importing `reverse` from the modern `django.urls`, which wasn't available on Django 1.6 / Review Board 3. They're now updated to fall back on the older import from `django.core.urlresolvers`, allowing tests to run on Review Board 3.	4decbbe62796cd007f4947aeeed67c0936b0d970

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (3d361fe)

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (3d361fe)