Summary

Add support for all features on Index objects through Django 4.0.

Review Request #12214 — Created March 28, 2022 and submitted April 8, 2022, 8:39 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

release-2.x

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

Django Evolution has supported Meta.indexes and the Index object for

a while, but lacked an assortment of features present since Django 2.0.

These include:

db_tablespace (Django 2.0+)
condition (Django 2.2+)
opclasses (Django 2.2+)
expressions (Django 3.2+)
include (Django 3.2+)

This change introduces support for all of these features, allowing them

to evolve successfully.

Testing Done

Unit tests pass on all supported versions of Python, Django, and all
databases.

Commits

Summary	ID
Add support for all features on Index objects through Django 4.0. Django Evolution has supported `Meta.indexes` and the `Index` object for a while, but lacked an assortment of features present since Django 2.0. These include: * `db_tablespace` (Django 2.0+) * `condition` (Django 2.2+) * `opclasses` (Django 2.2+) * `expressions` (Django 3.2+) * `include` (Django 3.2+) This change introduces support for all of these features, allowing them to evolve successfully.	f672bdb1d20edd24ebe409b56eb72c34e72318b0

Summary

Add support for all features on Index objects through Django 4.0.

Django Evolution has supported `Meta.indexes` and the `Index` object for a while, but lacked an assortment of features present since Django 2.0. These include: * `db_tablespace` (Django 2.0+) * `condition` (Django 2.2+) * `opclasses` (Django 2.2+) * `expressions` (Django 3.2+) * `include` (Django 3.2+) This change introduces support for all of these features, allowing them to evolve successfully.

f672bdb1d20edd24ebe409b56eb72c34e72318b0

Issues

Description	From	Last Updated
Docstring?	david	April 5, 2022, 4:25 p.m.
Leftover debug output.	david	April 5, 2022, 4:25 p.m.
Leftover debug output.	david	April 5, 2022, 4:25 p.m.

flake8 passed.

JSHint passed.

django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Docstring?
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Leftover debug output.
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Leftover debug output.
```

Change Summary:


Added a missing docstring.
Removed leftover debug output.

Commits:

	Summary	ID
	Add support for all features on Index objects through Django 4.0. Django Evolution has supported `Meta.indexes` and the `Index` object for a while, but lacked an assortment of features present since Django 2.0. These include: * `db_tablespace` (Django 2.0+) * `condition` (Django 2.2+) * `opclasses` (Django 2.2+) * `expressions` (Django 3.2+) * `include` (Django 3.2+) This change introduces support for all of these features, allowing them to evolve successfully.	4dadac54cd98f678ee19cd66aeb8a9f80dd10dbe
	Add support for all features on Index objects through Django 4.0. Django Evolution has supported `Meta.indexes` and the `Index` object for a while, but lacked an assortment of features present since Django 2.0. These include: * `db_tablespace` (Django 2.0+) * `condition` (Django 2.2+) * `opclasses` (Django 2.2+) * `expressions` (Django 3.2+) * `include` (Django 3.2+) This change introduces support for all of these features, allowing them to evolve successfully.	f36ce955500de4b8c8a594b1a3d5d6ceac5466ad

Diff:

Revision 2 (+1840 -132)

Show changes

	django_evolution/diff.py
	django_evolution/mock_models.py
	django_evolution/mutations.py
	django_evolution/mutators.py
	django_evolution/db/common.py
	django_evolution/db/state.py
	django_evolution/tests/test_change_meta.py
	django_evolution/tests/db/mysql.py
	2 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Fixed the version number in Version Added to be 2.2 instead of 2.3.

Commits:

	Summary	ID
	Add support for all features on Index objects through Django 4.0. Django Evolution has supported `Meta.indexes` and the `Index` object for a while, but lacked an assortment of features present since Django 2.0. These include: * `db_tablespace` (Django 2.0+) * `condition` (Django 2.2+) * `opclasses` (Django 2.2+) * `expressions` (Django 3.2+) * `include` (Django 3.2+) This change introduces support for all of these features, allowing them to evolve successfully.	f36ce955500de4b8c8a594b1a3d5d6ceac5466ad
	Add support for all features on Index objects through Django 4.0. Django Evolution has supported `Meta.indexes` and the `Index` object for a while, but lacked an assortment of features present since Django 2.0. These include: * `db_tablespace` (Django 2.0+) * `condition` (Django 2.2+) * `opclasses` (Django 2.2+) * `expressions` (Django 3.2+) * `include` (Django 3.2+) This change introduces support for all of these features, allowing them to evolve successfully.	f672bdb1d20edd24ebe409b56eb72c34e72318b0

Diff:

Revision 3 (+1840 -132)

Show changes

	django_evolution/diff.py
	django_evolution/mock_models.py
	django_evolution/mutations.py
	django_evolution/mutators.py
	django_evolution/db/common.py
	django_evolution/db/state.py
	django_evolution/tests/test_change_meta.py
	django_evolution/tests/db/mysql.py
	2 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.x (e02945c)