Summary

[WIP] Add functions for triggering an immediate update

Review Request #11861 — Created Oct. 21, 2021 and discarded Nov. 26, 2021, 4:28 p.m.

Information

Owner

cynthia

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

kAdd a new function "giveImmediateUpdates" in reviewRequestPageModel.js.

Let the view render the entry contents only when the entry box is not collapsed.

Modify the extend() and collapse() in the entryView class
TODO: 

1. make sure collapsed review entries are not being loaded initially

2. remove console.log and other debugging code

Testing Done

WIP
Not tested

Commits

Summary	ID	Author
add console log for debug	e5efe2ddb94478ad7ed00ed9f96d6851a5894d43	Your Name

Issues

Description	From	Last Updated
Col: 54 Missing semicolon.	reviewbot	Oct. 21, 2021, 7:55 a.m.
I'm curious why we need to poke a value into this._watchedEntries here... where do we make use of it later …	mike_conley	Oct. 28, 2021, 8:25 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/reviewRequestPage/views/reviewEntryView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 54
 Missing semicolon.
```

Summary:

-	[WIP] Add function for triggering an immediate update
+	[WIP] Add functions for triggering an immediate update

Description:

		Add a new function "giveImmediateUpdates" to reviewRequestPageModel.js.
		Let the view render the entry contents only when the entry box is not collapsed.
		Changes to the base.html so the collapsed content doesn't have body element.
		TODO: Add a no-content state in base.html, so when an entry gets expanded we call
		the "giveImmediateUpdates" function when the entry does not have any content.
		TODO: Override the extend() function so it can trigger the "giveImmediateUpdates"
~		when needed
~		TODO: There might be syntax errors that need to be fixed
~		TODO: Remove redundant code
	~	when needed.
	~	TODO: There might be syntax errors that need to be fixed.
	~	TODO: Remove redundant code.

Description:

~		Add a new function "giveImmediateUpdates" to reviewRequestPageModel.js.
	~	Add a new function "giveImmediateUpdates" in reviewRequestPageModel.js.
		Let the view render the entry contents only when the entry box is not collapsed.
~		Changes to the base.html so the collapsed content doesn't have body element.
~		TODO: Add a no-content state in base.html, so when an entry gets expanded we call
~		the "giveImmediateUpdates" function when the entry does not have any content.
~		TODO: Override the extend() function so it can trigger the "giveImmediateUpdates"
~		when needed.
	~	Modify the extend() and collapse() in the entryView class
	~
	~	TODO: Now the entry fetches for content whenever it gets expanded.
	~	Consider to add a “empty content” state in base.html, so when an entry gets expanded we call
	~	the "giveImmediateUpdates" function only when the entry does not have any content.
-		TODO: There might be syntax errors that need to be fixed.
-		TODO: Remove redundant code.

Commits:

Summary	ID	Author
initial changes	d6f8d6a10aaaf61f2dddb3202381106453240680	Your Name
draft	ff9f5c8763534d8a0ee2c2aeaa2a3b45d34c51cc	Your Name
draft	b36ffae52ce3d0700a33281dfeed55427c433f52	Your Name
my draft	bed6890f25bb2152d585357596ccd08722eb68e6	Your Name
initial changes	d6f8d6a10aaaf61f2dddb3202381106453240680	Your Name
draft	ff9f5c8763534d8a0ee2c2aeaa2a3b45d34c51cc	Your Name
draft	b36ffae52ce3d0700a33281dfeed55427c433f52	Your Name
my draft	bed6890f25bb2152d585357596ccd08722eb68e6	Your Name
modify the immediate() function	f2c9e654bdbf525a1600b08c7f144abc429ed995	Your Name

Diff:

Revision 2 (+231 -127)

Show changes

	reviewboard/static/rb/js/reviewRequestPage/models/entryModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/baseStatusUpdatesEntryView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/entryView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewEntryView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewRequestPageView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Fix it!

reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageModel.es6.js (Diff revision 2)

An issue was opened. Show all issues

I'm curious why we need to poke a value into this._watchedEntries here... where do we make use of it later on for this particular case? Because one of the side-effects here is now we have this entry added to the _watchedEntries array.

What happens if we don't write to _watchedEntries here, and we don't reset _this._watchedUpdatesLastScheduleTime, but instead just directly call:

  this._loadUpdates({
    entries: [entry],
    onDone: this._scheduleCheckUpdates.bind(this),
  });

cynthia Nov. 1, 2021, 5:55 p.m.

you are definitely right. There is no need to write to watchedEntries and reset _this._watchedUpdatesLastScheduleTime. I'll fix that. Thanks!

Commits:

Summary	ID	Author
initial changes	d6f8d6a10aaaf61f2dddb3202381106453240680	Your Name
draft	ff9f5c8763534d8a0ee2c2aeaa2a3b45d34c51cc	Your Name
draft	b36ffae52ce3d0700a33281dfeed55427c433f52	Your Name
my draft	bed6890f25bb2152d585357596ccd08722eb68e6	Your Name
modify the immediate() function	f2c9e654bdbf525a1600b08c7f144abc429ed995	Your Name
initial changes	d6f8d6a10aaaf61f2dddb3202381106453240680	Your Name
draft	ff9f5c8763534d8a0ee2c2aeaa2a3b45d34c51cc	Your Name
draft	b36ffae52ce3d0700a33281dfeed55427c433f52	Your Name
my draft	bed6890f25bb2152d585357596ccd08722eb68e6	Your Name
modify the immediate() function	f2c9e654bdbf525a1600b08c7f144abc429ed995	Your Name
remove adding entry in WtachedEntries in the immediate function	df3a1cc3ac55cae1dad584f81f89ba1f5f7a866c	Your Name

Diff:

Revision 3 (+226 -134)

Show changes

	reviewboard/static/rb/js/reviewRequestPage/models/entryModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/baseStatusUpdatesEntryView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/entryView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewEntryView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewRequestPageView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

~		Add a new function "giveImmediateUpdates" in reviewRequestPageModel.js.
	~	kAdd a new function "giveImmediateUpdates" in reviewRequestPageModel.js.
		Let the view render the entry contents only when the entry box is not collapsed.
		Modify the extend() and collapse() in the entryView class

		TODO: Now the entry fetches for content whenever it gets expanded.
		Consider to add a “empty content” state in base.html, so when an entry gets expanded we call
		the "giveImmediateUpdates" function only when the entry does not have any content.

Description:

		kAdd a new function "giveImmediateUpdates" in reviewRequestPageModel.js.
		Let the view render the entry contents only when the entry box is not collapsed.
		Modify the extend() and collapse() in the entryView class

~		TODO: Now the entry fetches for content whenever it gets expanded.
~		Consider to add a “empty content” state in base.html, so when an entry gets expanded we call
~		the "giveImmediateUpdates" function only when the entry does not have any content.
	~	TODO:
	~	1. make sure collapsed review entries are not being loaded initially
	~	2. remove console.log and other debugging code

Commits:

Summary	ID	Author
initial changes	d6f8d6a10aaaf61f2dddb3202381106453240680	Your Name
draft	ff9f5c8763534d8a0ee2c2aeaa2a3b45d34c51cc	Your Name
draft	b36ffae52ce3d0700a33281dfeed55427c433f52	Your Name
my draft	bed6890f25bb2152d585357596ccd08722eb68e6	Your Name
modify the immediate() function	f2c9e654bdbf525a1600b08c7f144abc429ed995	Your Name
remove adding entry in WtachedEntries in the immediate function	df3a1cc3ac55cae1dad584f81f89ba1f5f7a866c	Your Name
add console log for debug	e5efe2ddb94478ad7ed00ed9f96d6851a5894d43	Your Name

Diff:

Revision 4 (+168 -12)

Show changes

	reviewboard/static/rb/js/reviewRequestPage/models/entryModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/baseStatusUpdatesEntryView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/entryView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewEntryView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewRequestPageView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Review Board 7.0 alpha 0 (dev)

[WIP] Add functions for triggering an immediate update

Information

Reviewers

JSHint

Summary:

Description:

Description:

Commits:

Diff:

Checks run (2 succeeded)

Commits:

Diff:

Checks run (2 succeeded)

Description:

Description:

Commits:

Diff:

Checks run (2 succeeded)

Status: Discarded