Summary

JSON Output for RBTools List-Repo-Types Command

Review Request #11573 — Created April 4, 2021 and discarded Oct. 25, 2021, 1:23 p.m.

Information

Owner

ryankang

Repository

RBTools

Branch

master

Bugs

Depends On

~~11521~~

Reviewers

Groups

rbtools, students

People

Description

Depends on JSON output object from r#11521.

JSON object inclues:

types: List of all supported repo types with name and tool name of each

Testing Done

Ran unit tests in Commands and passed all tests

Commits

Summary	ID
Modified __init__.py print_clients method to return list of repo types list_repo_types iterates through repo_types returned from print_clients and appends to type key in json	19a49ce5f08269b54e3d9f380ffeb5dade6e259b
Fixed spaces on blank lines in __init__ clients and list_repo_types	f9316bec163c8379140a9b0d3be4f44a39141a1a

Issues

Description	From	Last Updated
W293 blank line contains whitespace	reviewbot	April 4, 2021, 2:07 p.m.
W293 blank line contains whitespace	reviewbot	April 4, 2021, 2:08 p.m.
W293 blank line contains whitespace	reviewbot	April 4, 2021, 2:08 p.m.
W293 blank line contains whitespace	reviewbot	April 4, 2021, 2:08 p.m.
E231 missing whitespace after ':'	reviewbot	April 4, 2021, 2:08 p.m.
E231 missing whitespace after ':'	reviewbot	April 4, 2021, 2:08 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/clients/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/clients/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/list_repo_types.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/list_repo_types.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```
rbtools/commands/list_repo_types.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```

Commits:

	Summary	ID
	Modified __init__.py print_clients method to return list of repo types list_repo_types iterates through repo_types returned from print_clients and appends to type key in json	19a49ce5f08269b54e3d9f380ffeb5dade6e259b
	Modified __init__.py print_clients method to return list of repo types list_repo_types iterates through repo_types returned from print_clients and appends to type key in json	19a49ce5f08269b54e3d9f380ffeb5dade6e259b
	Fixed spaces on blank lines in __init__ clients and list_repo_types	f9316bec163c8379140a9b0d3be4f44a39141a1a

Diff:

Revision 2 (+35 -7)

Show changes

	rbtools/clients/__init__.py
	rbtools/commands/list_repo_types.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	[WIP] JSON Output for RBTools List-Repo-Types Command
+	JSON Output for RBTools List-Repo-Types Command

Depends On:

+	~~11521 - JSON wrapper which inputs to a dictionary and outputs a JSON object~~

Groups:

+	students

Review Board 7.0 alpha 0 (dev)