Remove some hard-coded tool-specific config keys.

Review Request #11509 — Created March 10, 2021 and submitted

Information

ReviewBot
release-3.0.x

Reviewers

We had a couple tools (checkstyle and pmd) that assumed configuration
keys were present, and we were satisfying that assumption by hard-coding
keys in the Review Bot's default configuration.

This isn't entirely clean or future-proof, and we had no real reason to
do it. It inspired bad practices, and tied the core code to certain
tools.

Instead, those keys are now removed from the default configuration, and
the tools themselves are expected to conditionally check for the
presence of these keys.

New unit tests were added to check the resulting logic, with and without
configuration keys present.

Unit tests passed.

Summary ID
Remove some hard-coded tool-specific config keys.
We had a couple tools (checkstyle and pmd) that assumed configuration keys were present, and we were satisfying that assumption by hard-coding keys in the Review Bot's default configuration. This isn't entirely clean or future-proof, and we had no real reason to do it. It inspired bad practices, and tied the core code to certain tools. Instead, those keys are now removed from the default configuration, and the tools themselves are expected to conditionally check for the presence of these keys.
81d091bbe0f8881ca899cd62304d3e54968e0fe1
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (1d8039f)