flake8
-
reviewboard/reviews/tests/test_reviewtags.py (Diff revision 1)
Review Request #11397 — Created Jan. 22, 2021 and submitted
Change from
logging
tologger
because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.
I changedlogging
tologger
in modulesreviews
,webapi
andssh
.
Test using the tests in the
reviews
,webapi
andssh
modules' repositories. Using the following commands:./tests/runtests.py reviewboard.reviews.tests ./tests/runtests.py reviewboard.webapi.tests ./tests/runtests.py reviewboard.ssh.tests
All three test sets are passed.
Summary | ID |
---|---|
a419cc0b2427e5be2d4deb47b87da999d5a78fe1 | |
e7eb9144c776202c5aee8974c04c79e0488bbd26 | |
e13131c50f7a6f82326a34796276e76f1069e478 | |
1d094d90c87af6d2d990d439616fbfe788766c4f | |
dbf34a00d99a94b68799838b1336c4d81a1e4238 | |
a4b09e32a0c35941b4d51790a32881daabdda3f3 | |
f6b87711e0692b7a47c7700abc859b9096bdeb56 |
Description | From | Last Updated |
---|---|---|
Your summary probably doesn't need that second sentence about unit tests. |
david | |
E303 too many blank lines (2) |
reviewbot | |
You'll need to update the indentation on following lines to match, since "logger" is one character shorter than "logging". Here … |
david | |
Add an extra blank line above this. |
david | |
Add an extra blank line above this. |
david | |
This should have two blank lines after it. |
david | |
This should have two blank lines above and below. |
david | |
This should have two blank lines above and below. |
david | |
This should have two blank lines above and below. |
david | |
Let's move this down to happen just before the spy_on call. |
david | |
Let's move this down to happen just before the spy_on call. |
david | |
W293 blank line contains whitespace |
reviewbot |
Delete two extra line space before and after a variable import statement.
Commits: |
|
|||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+290 -162) |
reviewboard/reviews/detail.py (Diff revision 2) |
---|
You'll need to update the indentation on following lines to match, since "logger" is one character shorter than "logging". Here and in all the other changed places.
reviewboard/webapi/resources/base_original_file.py (Diff revision 2) |
---|
This should have two blank lines after it.
reviewboard/webapi/resources/diff.py (Diff revision 2) |
---|
This should have two blank lines above and below.
reviewboard/webapi/resources/review_request.py (Diff revision 2) |
---|
This should have two blank lines above and below.
reviewboard/webapi/resources/validate_diff.py (Diff revision 2) |
---|
This should have two blank lines above and below.
Keep the
logging.getLogger
statements inreviews
,ssh
andwebapi
modules with 2 lines of spaces above and below. Fix all one-char unaligned indentations due to the shorter logger string inreviews
,ssh
andwebapi
modules.
Summary: |
|
|||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
|||||||||||||||||||
Diff: |
Revision 3 (+544 -398) |
Looking really solid! Just two small suggestions.
reviewboard/reviews/tests/test_entries.py (Diff revision 3) |
---|
Let's move this down to happen just before the
spy_on
call.
reviewboard/reviews/tests/test_reviewtags.py (Diff revision 3) |
---|
Let's move this down to happen just before the
spy_on
call.
Move local import statements right before spy.
Commits: |
|
|||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+549 -401) |
Remove extra space on a new blank line
Commits: |
|
|||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+550 -402) |