Summary

Switch unit tests to the context manager form of assertRaisesMessage.

Review Request #10293 — Created Oct. 30, 2018 and submitted Nov. 1, 2018, 1:55 a.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

master

Bugs

Depends On

Commit

b74b1df...

Reviewers

Groups

django-evolution

People

Description

We have a lot of older unit tests that use the lambda form of
assertRaisesMessage, which is a bit more annoying to work with. This
was needed for older Python support. In preparation for some other
unit test changes, this change performs some cleanup on these calls,
switching to the context manager form in all calls.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
E303 too many blank lines (2)	reviewbot	Oct. 30, 2018, 6:37 p.m.
E303 too many blank lines (2)	reviewbot	Oct. 30, 2018, 6:37 p.m.
E131 continuation line unaligned for hanging indent	reviewbot	Oct. 30, 2018, 6:37 p.m.

flake8 failed.

JSHint passed.

flake8

django_evolution/tests/test_add_field.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```
django_evolution/tests/test_change_field.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```
django_evolution/tests/test_rename_model.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E131 continuation line unaligned for hanging indent
```

Change Summary:

Fixed some Review Bot warnings from a bad git add -p.

Commit:

db915ed319e88ad11ba23d445d0cd8ca759e5a95

b74b1df1a652159dd190a3713fd2a592de88da68

Diff:

Revision 2 (+226 -178)

Show changes

	django_evolution/tests/test_add_field.py
	django_evolution/tests/test_change_field.py
	django_evolution/tests/test_delete_app.py
	django_evolution/tests/test_delete_field.py
	django_evolution/tests/test_delete_model.py
	django_evolution/tests/test_rename_field.py
	django_evolution/tests/test_rename_model.py
	django_evolution/tests/test_sql_mutation.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (f281b14)