Inline text files in unit tests
Review Request #9971 — Created May 23, 2018 and submitted — Latest diff uploaded
Instead of the base test case opening and closing the same files
multiple times we have now moved the files inline with the code
resulting in a lower time complexity and a more streamline code design.
Re-ran the unit tests to make sure they behaved as expected.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 4. See what's changed.
orig
1
2
3
4
reviewboard/diffviewer/tests/test_diffset_manager.py |
---|
reviewboard/diffviewer/tests/test_filediff_migration.py |
---|
reviewboard/diffviewer/tests/test_forms.py |
---|
reviewboard/reviews/tests/test_review_request_draft.py |
---|
reviewboard/scmtools/testdata/git_binary.diff |
---|
reviewboard/scmtools/testdata/git_binary_image_modified.diff |
---|
reviewboard/scmtools/testdata/git_delfile.diff |
---|
reviewboard/scmtools/testdata/git_file_not_found.diff |
---|
reviewboard/scmtools/testdata/git_filemode.diff |
---|
reviewboard/scmtools/testdata/git_filemode2.diff |
---|
reviewboard/scmtools/testdata/git_newfile.diff |
---|
reviewboard/scmtools/testdata/git_newfile_nocontent.diff |
---|
reviewboard/scmtools/testdata/git_newfile_nocontent2.diff |
---|
reviewboard/scmtools/testdata/git_readme.diff |
---|
reviewboard/scmtools/testdata/git_simple.diff |
---|
reviewboard/scmtools/tests/test_git.py |
---|
reviewboard/testing/testcase.py |
---|
reviewboard/webapi/tests/test_diff.py |
---|
reviewboard/webapi/tests/test_draft_diff.py |
---|
reviewboard/webapi/tests/test_draft_filediff.py |
---|
reviewboard/webapi/tests/test_validate_diff.py |
---|