• 
      

    Fix a crash when generating PII-safe URLs with non-strings in kwargs.

    Review Request #9963 — Created May 22, 2018 and submitted

    Information

    Djblets
    release-1.0.x
    7f63a29...

    Reviewers

    When generating PII-safe URLs, we attempt to analyze the content of any
    values coming into the view from the keyword arguments. If something
    comes in that's not a string, this can crash, and that'll happen any
    time extra context is provided to a view (like a form class).

    We now check the value type prior to checking the content.

    Unit tests pass.

    Tested with a view that crashed. Verified this fixed it.

    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-1.0.x (55b6e02)